TechnoHector/suyu
2
1
Fork 0
forked from suyu/suyu
Code Pull requests Activity

game_list_worker: Use QString's formatting instead of fmt in FormatPatchNameVersions()

Browse source 
Using fmt here requires unnecessary string conversions back into
QString. Instead, we can just use QString's formatting and get the end
result of the formatting operation in the proper type.
This commit is contained in:
Lioncash 2018-10-24 11:25:55 -04:00
parent 77e705a8fa
commit 1edf8660bc
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/yuzu/game_list_worker.cpp
View file

@ -62,19 +62,24 @@ QString FormatPatchNameVersions(const FileSys::PatchManager& patch_manager,
FileSys::VirtualFile update_raw;
loader.ReadUpdateRaw(update_raw);
for (const auto& kv : patch_manager.GetPatchVersionNames(update_raw)) {
if (!updatable && kv.first == "Update")
const bool is_update = kv.first == "Update";
if (!updatable && is_update) {
continue;
}
const QString type = QString::fromStdString(kv.first);
if (kv.second.empty()) {
out.append(fmt::format("{}\n", kv.first).c_str());
out.append(QStringLiteral("%1\n").arg(type));
} else {
auto ver = kv.second;
// Display container name for packed updates
if (ver == "PACKED" && kv.first == "Update")
if (is_update && ver == "PACKED") {
ver = Loader::GetFileTypeString(loader.GetFileType());
}
out.append(fmt::format("{} ({})\n", kv.first, ver).c_str());
out.append(QStringLiteral("%1 (%2)\n").arg(type, QString::fromStdString(ver)));
}
}