1
1
Fork 0
forked from suyu/suyu

configure_hotkeys: Pass the dialog as a parent to SequenceDialog()

Without passing in a parent, this can result in focus being stolen from
the dialog in certain cases.

Example:

On Windows, if the logging window is left open, the logging Window will
potentially get focus over the hotkey dialog itself, since it brings all
open windows for the application into view. By specifying a parent, we
only bring windows for the parent into view (of which there are none,
aside from the hotkey dialog).
This commit is contained in:
Lioncash 2019-04-09 20:06:45 -04:00
parent b47c0c8a80
commit e1101d3e20

View file

@ -74,7 +74,7 @@ void ConfigureHotkeys::Configure(QModelIndex index) {
auto* const model = ui->hotkey_list->model();
const auto previous_key = model->data(index);
SequenceDialog hotkey_dialog;
SequenceDialog hotkey_dialog{this};
const int return_code = hotkey_dialog.exec();
const auto key_sequence = hotkey_dialog.GetSequence();