Nikilite/suyu
1
1
Fork 0
forked from suyu/suyu
Code Pull requests Activity

dedicated_room: fix token padding ...

Browse source 
... mebedtls' base64 routine has a strange behavioral issue where if the
input is invalid, it will not report it as invalid, but rather returning
a bunch of garbage data. This new round-tripping padding method should
eliminate such issue.
This commit is contained in:
liushuyu 2022-09-10 17:38:36 -06:00 committed by Narr the Reg
parent 1694c55d62
commit aa11d73bba
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/dedicated_room/yuzu_room.cpp
View file

@ -76,8 +76,18 @@ static constexpr char BanListMagic[] = "YuzuRoom-BanList-1";
static constexpr char token_delimiter{':'}; static constexpr char token_delimiter{':'};
static void PadToken(std::string& token) { static void PadToken(std::string& token) {
const auto remainder = token.size() % 3; std::size_t outlen = 0;
for (size_t i = 0; i < (3 - remainder); i++) {
std::array<unsigned char, 512> output{};
std::array<unsigned char, 2048> roundtrip{};
for (size_t i = 0; i < 3; i++) {
mbedtls_base64_decode(output.data(), output.size(), &outlen,
reinterpret_cast<const unsigned char*>(token.c_str()),
token.length());
mbedtls_base64_encode(roundtrip.data(), roundtrip.size(), &outlen, output.data(), outlen);
if (memcmp(roundtrip.data(), token.data(), token.size()) == 0) {
break;
}
token.push_back('='); token.push_back('=');
} }
} }