Nikilite/suyu
1
1
Fork 0
forked from suyu/suyu
Code Pull requests Activity

fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()

Browse source 
Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
This commit is contained in:
Lioncash 2020-08-23 16:37:54 -04:00
parent 3ea3de4ecd
commit 85db5f4091
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/core/hle/service/filesystem/fsp_srv.cpp
View file

@ -844,8 +844,7 @@ void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) {
return;
}
FileSys::StorageId id;
FileSys::StorageId id{};
switch (parameters.space_id) {
case FileSys::SaveDataSpaceId::NandUser:
id = FileSys::StorageId::NandUser;
@ -857,6 +856,10 @@ void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) {
case FileSys::SaveDataSpaceId::NandSystem:
id = FileSys::StorageId::NandSystem;
break;
case FileSys::SaveDataSpaceId::TemporaryStorage:
case FileSys::SaveDataSpaceId::ProperSystem:
case FileSys::SaveDataSpaceId::SafeMode:
UNREACHABLE();
}
auto filesystem =