Nikilite/suyu
1
1
Fork 0
forked from suyu/suyu
Code Pull requests Activity

logging/backend: Use std::string_view in RemoveBackend() and GetBackend()

Browse source 
These can just use a view to a string since its only comparing against
two names in both cases for matches. This avoids constructing
std::string instances where they aren't necessary.
This commit is contained in:
Lioncash 2018-07-20 15:27:17 -04:00
parent c1c9ab31e8
commit 457d1b4490
2 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/common/logging/backend.cpp
View file

@ -48,11 +48,11 @@ public:
backends.push_back(std::move(backend));
}
void RemoveBackend(const std::string& backend_name) {
void RemoveBackend(std::string_view backend_name) {
std::lock_guard<std::mutex> lock(writing_mutex);
auto it = std::remove_if(backends.begin(), backends.end(), [&backend_name](const auto& i) {
return !strcmp(i->GetName(), backend_name.c_str());
});
const auto it =
std::remove_if(backends.begin(), backends.end(),
[&backend_name](const auto& i) { return backend_name == i->GetName(); });
backends.erase(it, backends.end());
}
@ -64,10 +64,10 @@ public:
filter = f;
}
Backend* GetBackend(const std::string& backend_name) {
auto it = std::find_if(backends.begin(), backends.end(), [&backend_name](const auto& i) {
return !strcmp(i->GetName(), backend_name.c_str());
});
Backend* GetBackend(std::string_view backend_name) {
const auto it =
std::find_if(backends.begin(), backends.end(),
[&backend_name](const auto& i) { return backend_name == i->GetName(); });
if (it == backends.end())
return nullptr;
return it->get();
@ -265,11 +265,11 @@ void AddBackend(std::unique_ptr<Backend> backend) {
Impl::Instance().AddBackend(std::move(backend));
}
void RemoveBackend(const std::string& backend_name) {
void RemoveBackend(std::string_view backend_name) {
Impl::Instance().RemoveBackend(backend_name);
}
Backend* GetBackend(const std::string& backend_name) {
Backend* GetBackend(std::string_view backend_name) {
return Impl::Instance().GetBackend(backend_name);
}

5
src/common/logging/backend.h
View file

@ -7,6 +7,7 @@
#include <cstdarg>
#include <memory>
#include <string>
#include <string_view>
#include <utility>
#include "common/file_util.h"
#include "common/logging/filter.h"
@ -106,9 +107,9 @@ private:
void AddBackend(std::unique_ptr<Backend> backend);
void RemoveBackend(const std::string& backend_name);
void RemoveBackend(std::string_view backend_name);
Backend* GetBackend(const std::string& backend_name);
Backend* GetBackend(std::string_view backend_name);
/**
* Returns the name of the passed log class as a C-string. Subclasses are separated by periods