forked from suyu/suyu
76ca2a5f82
Nvidia's OpenGL driver maps gl(Named)BufferSubData with some requirements to a fast. This path has an extra memcpy but updates the buffer without orphaning or waiting for previous calls. It can be seen as a better model for "push constants" that can upload a whole UBO instead of 256 bytes. This path has some requirements established here: http://on-demand.gputechconf.com/gtc/2014/presentations/S4379-opengl-44-scene-rendering-techniques.pdf#page=24 Instead of using the stream buffer, this commits moves constant buffers uploads to calls of glNamedBufferSubData and from my testing it brings a performance improvement. This is disabled when the vendor is not Nvidia since it brings performance regressions.
95 lines
3.5 KiB
C++
95 lines
3.5 KiB
C++
// Copyright 2018 yuzu Emulator Project
|
|
// Licensed under GPLv2 or any later version
|
|
// Refer to the license.txt file included.
|
|
|
|
#include <memory>
|
|
|
|
#include <glad/glad.h>
|
|
|
|
#include "common/assert.h"
|
|
#include "common/microprofile.h"
|
|
#include "video_core/engines/maxwell_3d.h"
|
|
#include "video_core/rasterizer_interface.h"
|
|
#include "video_core/renderer_opengl/gl_buffer_cache.h"
|
|
#include "video_core/renderer_opengl/gl_device.h"
|
|
#include "video_core/renderer_opengl/gl_rasterizer.h"
|
|
#include "video_core/renderer_opengl/gl_resource_manager.h"
|
|
|
|
namespace OpenGL {
|
|
|
|
using Maxwell = Tegra::Engines::Maxwell3D::Regs;
|
|
|
|
MICROPROFILE_DEFINE(OpenGL_Buffer_Download, "OpenGL", "Buffer Download", MP_RGB(192, 192, 128));
|
|
|
|
CachedBufferBlock::CachedBufferBlock(CacheAddr cache_addr, const std::size_t size)
|
|
: VideoCommon::BufferBlock{cache_addr, size} {
|
|
gl_buffer.Create();
|
|
glNamedBufferData(gl_buffer.handle, static_cast<GLsizeiptr>(size), nullptr, GL_DYNAMIC_DRAW);
|
|
}
|
|
|
|
CachedBufferBlock::~CachedBufferBlock() = default;
|
|
|
|
OGLBufferCache::OGLBufferCache(RasterizerOpenGL& rasterizer, Core::System& system,
|
|
const Device& device, std::size_t stream_size)
|
|
: GenericBufferCache{rasterizer, system, std::make_unique<OGLStreamBuffer>(stream_size, true)} {
|
|
if (!device.HasFastBufferSubData()) {
|
|
return;
|
|
}
|
|
|
|
static constexpr auto size = static_cast<GLsizeiptr>(Maxwell::MaxConstBufferSize);
|
|
glCreateBuffers(static_cast<GLsizei>(std::size(cbufs)), std::data(cbufs));
|
|
for (const GLuint cbuf : cbufs) {
|
|
glNamedBufferData(cbuf, size, nullptr, GL_STREAM_DRAW);
|
|
}
|
|
}
|
|
|
|
OGLBufferCache::~OGLBufferCache() {
|
|
glDeleteBuffers(static_cast<GLsizei>(std::size(cbufs)), std::data(cbufs));
|
|
}
|
|
|
|
Buffer OGLBufferCache::CreateBlock(CacheAddr cache_addr, std::size_t size) {
|
|
return std::make_shared<CachedBufferBlock>(cache_addr, size);
|
|
}
|
|
|
|
void OGLBufferCache::WriteBarrier() {
|
|
glMemoryBarrier(GL_ALL_BARRIER_BITS);
|
|
}
|
|
|
|
const GLuint* OGLBufferCache::ToHandle(const Buffer& buffer) {
|
|
return buffer->GetHandle();
|
|
}
|
|
|
|
const GLuint* OGLBufferCache::GetEmptyBuffer(std::size_t) {
|
|
static const GLuint null_buffer = 0;
|
|
return &null_buffer;
|
|
}
|
|
|
|
void OGLBufferCache::UploadBlockData(const Buffer& buffer, std::size_t offset, std::size_t size,
|
|
const u8* data) {
|
|
glNamedBufferSubData(*buffer->GetHandle(), static_cast<GLintptr>(offset),
|
|
static_cast<GLsizeiptr>(size), data);
|
|
}
|
|
|
|
void OGLBufferCache::DownloadBlockData(const Buffer& buffer, std::size_t offset, std::size_t size,
|
|
u8* data) {
|
|
MICROPROFILE_SCOPE(OpenGL_Buffer_Download);
|
|
glGetNamedBufferSubData(*buffer->GetHandle(), static_cast<GLintptr>(offset),
|
|
static_cast<GLsizeiptr>(size), data);
|
|
}
|
|
|
|
void OGLBufferCache::CopyBlock(const Buffer& src, const Buffer& dst, std::size_t src_offset,
|
|
std::size_t dst_offset, std::size_t size) {
|
|
glCopyNamedBufferSubData(*src->GetHandle(), *dst->GetHandle(),
|
|
static_cast<GLintptr>(src_offset), static_cast<GLintptr>(dst_offset),
|
|
static_cast<GLsizeiptr>(size));
|
|
}
|
|
|
|
OGLBufferCache::BufferInfo OGLBufferCache::ConstBufferUpload(const void* raw_pointer,
|
|
std::size_t size) {
|
|
DEBUG_ASSERT(cbuf_cursor < std::size(cbufs));
|
|
const GLuint& cbuf = cbufs[cbuf_cursor++];
|
|
glNamedBufferSubData(cbuf, 0, static_cast<GLsizeiptr>(size), raw_pointer);
|
|
return {&cbuf, 0};
|
|
}
|
|
|
|
} // namespace OpenGL
|