Exverge/suyu
3
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

logging/backend: Make time_origin a class variable instead of a local static

Browse source 
Moves local global state into the Impl class itself and initializes it
at the creation of the instance instead of in the function.

This makes it nicer for weakly-ordered architectures, given the
CreateEntry() class won't need to have atomic loads executed for each
individual call to the CreateEntry class.
This commit is contained in:
Lioncash 2019-03-02 14:28:58 -05:00
parent 43c1092031
commit f8f1ff0b4f
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/common/logging/backend.cpp
View file

@ -115,8 +115,6 @@ private:
using std::chrono::duration_cast; using std::chrono::duration_cast;
using std::chrono::steady_clock; using std::chrono::steady_clock;
static steady_clock::time_point time_origin = steady_clock::now();
Entry entry; Entry entry;
entry.timestamp = entry.timestamp =
duration_cast<std::chrono::microseconds>(steady_clock::now() - time_origin); duration_cast<std::chrono::microseconds>(steady_clock::now() - time_origin);
@ -135,6 +133,7 @@ private:
std::vector<std::unique_ptr<Backend>> backends; std::vector<std::unique_ptr<Backend>> backends;
Common::MPSCQueue<Log::Entry> message_queue; Common::MPSCQueue<Log::Entry> message_queue;
Filter filter; Filter filter;
std::chrono::steady_clock::time_point time_origin{std::chrono::steady_clock::now()};
}; };
void ConsoleBackend::Write(const Entry& entry) { void ConsoleBackend::Write(const Entry& entry) {