Exverge/suyu
3
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

telemetry_json: Take std::string parameters by value

Browse source 
Taking them by const reference isn't advisable here, because it means
the std::move calls were doing nothing and we were always copying the
std::string instances.
This commit is contained in:
Lioncash 2018-10-10 20:59:25 -04:00
parent a34e5e51d8
commit 881bb2295d
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/web_service/telemetry_json.cpp
View file

@ -8,8 +8,7 @@
namespace WebService {
TelemetryJson::TelemetryJson(const std::string& host, const std::string& username,
const std::string& token)
TelemetryJson::TelemetryJson(std::string host, std::string username, std::string token)
: host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
TelemetryJson::~TelemetryJson() = default;

2
src/web_service/telemetry_json.h
View file

@ -18,7 +18,7 @@ namespace WebService {
*/
class TelemetryJson : public Telemetry::VisitorInterface {
public:
TelemetryJson(const std::string& host, const std::string& username, const std::string& token);
TelemetryJson(std::string host, std::string username, std::string token);
~TelemetryJson();
void Visit(const Telemetry::Field<bool>& field) override;