3
0
Fork 0
forked from suyu/suyu

game_list: Use QJsonValueRef() within LoadCompatibilityList()

This way, we aren't constructing unnecessary QJsonValue instances.
This commit is contained in:
Lioncash 2018-09-11 22:28:28 -04:00
parent 1470b85af9
commit 7fe10dea3e

View file

@ -366,7 +366,7 @@ void GameList::LoadCompatibilityList() {
QJsonDocument json = QJsonDocument::fromJson(string_content.toUtf8()); QJsonDocument json = QJsonDocument::fromJson(string_content.toUtf8());
QJsonArray arr = json.array(); QJsonArray arr = json.array();
for (const QJsonValue& value : arr) { for (const QJsonValueRef& value : arr) {
QJsonObject game = value.toObject(); QJsonObject game = value.toObject();
if (game.contains("compatibility") && game["compatibility"].isDouble()) { if (game.contains("compatibility") && game["compatibility"].isDouble()) {
@ -374,7 +374,7 @@ void GameList::LoadCompatibilityList() {
QString directory = game["directory"].toString(); QString directory = game["directory"].toString();
QJsonArray ids = game["releases"].toArray(); QJsonArray ids = game["releases"].toArray();
for (const QJsonValue& value : ids) { for (const QJsonValueRef& value : ids) {
QJsonObject object = value.toObject(); QJsonObject object = value.toObject();
QString id = object["id"].toString(); QString id = object["id"].toString();
compatibility_list.emplace( compatibility_list.emplace(