Exverge/suyu
3
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

Merge pull request #7825 from lioncash/nodisc2

Browse source 
common/file: Remove [[nodiscard]] from Open()
This commit is contained in:
Morph 2022-02-01 02:29:36 -05:00 committed by GitHub
commit 7432343214
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/common/fs/file.h
View file

@ -188,8 +188,7 @@ public:
#ifdef _WIN32 #ifdef _WIN32
template <typename Path> template <typename Path>
[[nodiscard]] void Open(const Path& path, FileAccessMode mode, void Open(const Path& path, FileAccessMode mode, FileType type = FileType::BinaryFile,
FileType type = FileType::BinaryFile,
FileShareFlag flag = FileShareFlag::ShareReadOnly) { FileShareFlag flag = FileShareFlag::ShareReadOnly) {
using ValueType = typename Path::value_type; using ValueType = typename Path::value_type;
if constexpr (IsChar<ValueType>) { if constexpr (IsChar<ValueType>) {