Diabolic/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

renderer_base: Removed redundant settings

Browse source 
use_framelimiter was not being used internally by the renderers.
set_background_color was always set to true as there is no toggle for the renderer background color, instead users directly choose the color of their choice.
This commit is contained in:
ameerj 2021-07-22 20:08:01 -04:00
parent 9dfbc9bdce
commit c80ae87b4e
3 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/video_core/renderer_base.cpp
View file

@ -19,9 +19,6 @@ RendererBase::~RendererBase() = default;
void RendererBase::RefreshBaseSettings() { void RendererBase::RefreshBaseSettings() {
UpdateCurrentFramebufferLayout(); UpdateCurrentFramebufferLayout();
renderer_settings.use_framelimiter = Settings::values.use_speed_limit.GetValue();
renderer_settings.set_background_color = true;
} }
void RendererBase::UpdateCurrentFramebufferLayout() { void RendererBase::UpdateCurrentFramebufferLayout() {

3
src/video_core/renderer_base.h
View file

@ -21,9 +21,6 @@ class GraphicsContext;
namespace VideoCore { namespace VideoCore {
struct RendererSettings { struct RendererSettings {
std::atomic_bool use_framelimiter{false};
std::atomic_bool set_background_color{false};
// Screenshot // Screenshot
std::atomic<bool> screenshot_requested{false}; std::atomic<bool> screenshot_requested{false};
void* screenshot_bits{}; void* screenshot_bits{};

10
src/video_core/renderer_opengl/renderer_opengl.cpp
View file

@ -332,12 +332,10 @@ void RendererOpenGL::ConfigureFramebufferTexture(TextureInfo& texture,
} }
void RendererOpenGL::DrawScreen(const Layout::FramebufferLayout& layout) { void RendererOpenGL::DrawScreen(const Layout::FramebufferLayout& layout) {
if (renderer_settings.set_background_color) { // Update background color before drawing
// Update background color before drawing glClearColor(Settings::values.bg_red.GetValue() / 255.0f,
glClearColor(Settings::values.bg_red.GetValue() / 255.0f, Settings::values.bg_green.GetValue() / 255.0f,
Settings::values.bg_green.GetValue() / 255.0f, Settings::values.bg_blue.GetValue() / 255.0f, 1.0f);
Settings::values.bg_blue.GetValue() / 255.0f, 1.0f);
}
// Set projection matrix // Set projection matrix
const std::array ortho_matrix = const std::array ortho_matrix =