This updates systemd to version v249.4 from version v247.6.
Besides the many new features that can be found in the upstream
repository they also introduced a bunch of cleanup which ended up
requiring a few more patches on our side.
a) 0022-core-Handle-lookup-paths-being-symlinks.patch:
The way symlinked units were handled was changed in such that the last
name of a unit file within one of the unit directories
(/run/systemd/system, /etc/systemd/system, ...) is used as the name
for the unit. Unfortunately that code didn't take into account that
the unit directories themselves could already be symlinks and thus
caused all our units to be recognized slightly different.
There is an upstream PR for this new patch:
https://github.com/systemd/systemd/pull/20479
b) The way the APIVFS is setup has been changed in such a way that we
now always have /run. This required a few changes to the
confinement tests which did assert that they didn't exist. Instead of
adding another patch we can just adopt the upstream behavior. An
empty /run doesn't seem harmful.
As part of this work I refactored the confinement test just a little
bit to allow better debugging of test failures. Previously it would
just fail at some point and it wasn't obvious which of the many
commands failed or what the unexpected string was. This should now be
more obvious.
c) Again related to the confinement tests the way a file was tested for
being accessible was optimized. Previously systemd would in some
situations open a file twice during that check. This was reduced to
one operation but required the procfs to be mounted in a units
namespace.
An upstream bug was filed and fixed. We are now carrying the
essential patch to fix that issue until it is backported to a new
release (likely only version 250). The good part about this story is
that upstream systemd now has a test case that looks very similar to
one of our confinement tests. Hopefully that will lead to less
friction in the long run.
https://github.com/systemd/systemd/issues/20514https://github.com/systemd/systemd/pull/20515
d) Previously we could grep for dlopen( somewhat reliably but now
upstream started using a wrapper around dlopen that is most of the
time used with linebreaks. This makes using grep not ergonomic
anymore.
With this bump we are grepping for anything that looks like a
dynamic library name (in contrast to a dlopen(3) call) and replace
those instead. That seems more robust. Time will tell if this holds.
I tried using coccinelle to patch all those call sites using its
tooling but unfornately it does stumble upon the _cleanup_
annotations that are very common in the systemd code.
e) We now have some machinery for libbpf support in our systemd build.
That being said it doesn't actually work as generating some skeletons
doesn't work just yet. It fails with the below error message and is
disabled by default (in both minimal and the regular build).
> FAILED: src/core/bpf/socket_bind/socket-bind.skel.h
> /build/source/tools/build-bpf-skel.py --clang_exec /nix/store/x1bi2mkapk1m0zq2g02nr018qyjkdn7a-clang-wrapper-12.0.1/bin/clang --llvm_strip_exec /nix/store/zm0kqan9qc77x219yihmmisi9g3sg8ns-llvm-12.0.1/bin/llvm-strip --bpftool_exec /nix/store/l6dg8jlbh8qnqa58mshh3d8r6999dk0p-bpftools-5.13.11/bin/bpftool --arch x86_64 ../src/core/bpf/socket_bind/socket-bind.bpf.c src/core/bpf/socket_bind/socket-bind.skel.h
> libbpf: elf: socket_bind_bpf is not a valid eBPF object file
> Error: failed to open BPF object file: BPF object format invalid
> Traceback (most recent call last):
> File "/build/source/tools/build-bpf-skel.py", line 128, in <module>
> bpf_build(args)
> File "/build/source/tools/build-bpf-skel.py", line 92, in bpf_build
> gen_bpf_skeleton(bpftool_exec=args.bpftool_exec,
> File "/build/source/tools/build-bpf-skel.py", line 63, in gen_bpf_skeleton
> skel = subprocess.check_output(bpftool_args, universal_newlines=True)
> File "/nix/store/81lwy2hfqj4c1943b1x8a0qsivjhdhw9-python3-3.9.6/lib/python3.9/subprocess.py", line 424, in check_output
> return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
> File "/nix/store/81lwy2hfqj4c1943b1x8a0qsivjhdhw9-python3-3.9.6/lib/python3.9/subprocess.py", line 528, in run
> raise CalledProcessError(retcode, process.args,
> subprocess.CalledProcessError: Command '['/nix/store/l6dg8jlbh8qnqa58mshh3d8r6999dk0p-bpftools-5.13.11/bin/bpftool', 'g', 's', '../src/core/bpf/socket_bind/socket-bind.bpf.o']' returned non-zero exit status 255.
> [102/1457] Compiling C object src/journal/libjournal-core.a.p/journald-server.c.oapture output)put)ut)
> ninja: build stopped: subcommand failed.
f) We do now have support for TPM2 based disk encryption in our
systemd build. The actual bits and pieces to make use of that are
missing but there are various ongoing efforts in that direction.
There is also the story about systemd in our initrd to enable this
being used for root volumes. None of this will yet work out of the
box but we can start improving on that front.
g) FIDO2 support was added systemd and consequently we can now use
that. Just with TPM2 there hasn't been any integration work with
NixOS and instead this just adds that capability to work on that.
Co-Authored-By: Jörg Thalheim <joerg@thalheim.io>
This bumps systemd to the latest stable maintenance release.
- dc2e82af33 core: create per-user inaccessible node from the service manager
- 0b3c497347 nspawn,pid1: pass "inaccessible" nodes from cntr mgr to pid1 payload via /run/host
- 2239965c29 coredump: don't convert s → µs twice
- 61d29b7f8c firstboot: fill empty color if ansi_color unavailable from os-release
- 9678a3daf6 varlink: do not parse invalid messages twice
- 4e516dcbc1 userdbctl: add forgotten --output mode in help
- aee20dfbd8 shared/{user,group}-record-nss: adjust filtering of "valid" passwords
- 5933d77afe doc: cross link sd_listen_fd() docs a bit
- 97fdde3239 Rework how we cache mtime to figure out if units changed
- 0500968241 core: always try to reload not-found unit
- 8ae22f0d64 pid1: use the cache mtime not clock to "mark" load attempts
- 715507c277 core: rename manager_unit_file_maybe_loadable_from_cache()
- 20ad76d0a7 man: document fd ownership for sd-bus fd marshalling
- 38ae73fafd resolved: make sure we initialize t->answer_errno before completing the transaction
- a1ba0fbef6 homed: fix log message to honor real homework path
- d6b1e659b3 src/shared/dissect-image.c: fix build without blkdid (#16901)
- e42f9add21 analyze: fix error handling in one case
- 4804ce1488 units: add missing usb-gadget.target
- 5ad4e68c37 man: extend on the usec/sec discrepancy
- 2fb612371d login/logind: Include sys/stat.h for struct stat usage
- 5e884e7ee0 partition/makefs: Include missing sys/file.h header
- 7bbc3807da network: dhcp6: logs only new address
- 2056429e0f Don't run test-repart when loop devices are not available
- dcbea51c5a man: clarify that several networkctl commands takes device names
- 16e4cfcc82 networkctl: label command does not take any argument
- 2352921244 missing: Add new Linux capability
- 8b29c4a4f9 tty-ask-pw-agent: properly propagate error
- f7ce2e9839 tty-ask-pw-agent: the message string might not be set
- 29cba5c9ef tty-ask-pw-agent: make sure "--list" works correctly
- e1ce367d73 add "list" verb to autocompleted commands
- 1f4cb5da1e shell-completion/zsh: add missing verbs for networkctl
- a4236a2764 path: Improve $PATH search directory case
- b7cef386bd path: Skip directories when finalising $PATH search
- 122945f315 rules: don't install 80-drivers.rules when kmod is disabled
- 42fab2d454 zsh: correct journalctl command completion parsing
- ed3f97f962 basic/missing_syscall: fix syscall numbers for arm64 :(
- ba6e7f7c46 shared/install: fix preset operations for non-service instantiated units
- d39f139348 nss-resolve: treat BUS_ERROR_NO_SUCH_UNIT the same as SD_BUS_ERROR_SERVICE_UNKNOWN too
- 9bb3e64d71 various: treat BUS_ERROR_NO_SUCH_UNIT the same as SD_BUS_ERROR_SERVICE_UNKNOWN
- 6d802dd596 man: drop reference to long gone .busname unit type
- a29656804b man: fix a fix of a typo in systemd.service example
- 21ce0f5b33 network: can: Fix CAN initialization
- cab5cde8c9 man: update autogenerated dbus api lists
- 0d8000522b man: fix invalid tag place
- ea94f218be man: add conditionals to more man pages
- ef91325349 meson: add ENABLE_ANALYZE conditional
- 83f7c0a7ec core: add missing conditions/asserts to unit file parsing
- 716718155d analyze: rework condition testing
- 5c4c7581bc sd-bus: fix error handling on readv()
- 6cd058f305 user-runtime-dir: deal gracefully with missing logind properties
- 6a2d73638d shared/seccomp: do not use ifdef guards around textual syscall names
- 7355ac9689 machine-id-setup: don't use KVM or container manager supplied uuid if in chroot env
- 496a71f444 man: Fix typo in systemd-tmpfiles
- 6c5d216ad8 homework: downgrade chattr failure log message
- 1708f06a00 homework: explicitly close cryptsetup context, to not keep loopback device busy
- a21eaa2a3a homework: correct error passed into log message
- 3a2d169f36 homework: sync everything to disk before we rename LUKS loopback file into place
- 84e1ab74d2 homed: downgrade quota message in containers
- 8b62cadf36 analyze-security: do not assign badness to filtered-out syscalls
- 29854a5437 NEWS: clarify two points
- 4cb4fb82f7 meson: add min version for libfdisk
- 76331f86f6 load-fragment: fix grammar in error messages
- 1e53c2d70f Fix function description in logind man page
- 669066564d network: do not fail if UseMTU=yes on DHCP lease lost
- a2a3f16cdc missing_syscall: do not use function name that may conflict with glibc
- 4091dcd469 missing_syscall: fix pidfd_{send_signal,open} numbers for alpha
- 7875daf52b network: wait for previous address removal before configuring static addresses
- 120064b4a1 network: only process non-error message
- f44ec1de15 test: accept that char device 0/0 can now be created witout privileges
- 946e4c43bb tools/make-man-index: fix purpose text that contains tags
- dae0586e91 test-fs-util: skip encrypted path test if we get EACCES
- 0d026c9b0d Newer Glibc use faccessat2 to implement faccessat
- fde6520d46 namespace: fix minor memory leak
- 208ba581f4 man: fix incorrectly placed full stop
- 6c81d57828 man: fix typo
- 53a8d2588e bless-boot: add missing verb to --help
- 4cfa0ac4fd user-record: deal with invalid GECOS fields gracefully
- ae5234ef48 user-util: add mangle_gecos() call for turning strings into fields suitable as GECOS fields
- 972391ac39 fix typo in systemctl help
- 443aacfcda man: clarify that LogNamespace= is for system services only
- 5aec8fe54e _sd-common.h: avoid parsing errors with Coverity
- f9ad4ea2ca analyze: fix 'cat-config systemd/zram-generator.conf'
- dda6fec1df man: describe that changing Storage= does not move existing data
- 2bbd33e476 core: reset bus error before reuse
- b81504a3c7 nspawn: Fix incorrect usage of putenv
- cb263973ac man: fix typo in systemd.service
- 73b432e7ef network: fix DHCPv6 Prefix Delegation example after option rename
changes:
- aa0cb635f1 (tag: v245.6) network: L2TP fix crash
- 9774347b57 Fix typo.
- 2cac801f0f stat-util: trivial empty_or_null() tweaks
- b054e69bf9 Check ambient set against bounding set prior to applying ambient set
- bed695375a udev: when the BSD lock on a block device is taken, don't complain
- 66fcfdfde7 core: add forgotten return in error path
- 05dd19fad3 shared/efi-loader: remove check that uses absolute tick value
- 753a71ad1d gpt: include homed GPT partition type in well-known partition table
- 3668722049 units: don't set PrivateNetwork= in systemd-homed.service
- 2bca2d77d3 resolved-dns-query: remove dns_query_candidate_is_routable
- a3f6020432 sd-network: fix inverted error message
- a7a9fe3c93 network: allow empty assignment to PreferredLifetime=
- 8df6fc1241 Update resolvectl zsh completion
- c1a83277d0 shared: treat generator units as vendor units
- 1f382d818d tree-wide: fix bad errno checks
- 667c207683 bus-message: immediately reject messages with invalid type
- 116a8eadb6 bus-message: fix negative offset with ~empty message
- 4d5779d886 load-fragment: fix a typo
- c8b6de003a NEWS: retroactively document Family=
- cf6b8e6ec5 man: fix dir name in sysctl.d(5)
- 6d009b7a25 journalctl,elsewhere: make sure --file=foo fails with sane error msg if foo is not readable
- cf786ef164 makefs: log about OOM condition
- 0b1839822f blockdev: propagate one more unexpected error
- d78ce949d0 repart: don't insist on coming up on partition label ourselves
- 9e1363fcc6 journal: fix dropping first record during upload to remote journal
- 50cb4e418d meson: initialize time-epoch to reproducible builds compatible value
- 76abe079b7 limit-util: quieten a very common debug message that is misleading
- b3e484a3b1 shared: fix integer overflow in calendarspec
- 0c29eea969 repart: suppress complaints about lack of BLKRRPART when operating on regular file
- 3db52f5ed8 repart: explain when we exit early and don't do a thing
- d99cba3aaa mount: introduce mount_is_nofail() helper
- 7bc4bcea15 mount: default startup dependencies and default network ones are orthogonal
- 7fe617fa53 mount: introduce mount_add_default_ordering_dependencies()
- e1c091b6d4 automount: fix handling of default dependencies for automount units
- ae05a137c9 mount: let pid1 alone handle the default dependencies for mount units
- f1fb197176 mount: mount unit activated by automount unit should be only ordered against the automount unit
- c9bcc69703 generator: don't generate device dependencies for extrinsic mounts
- ebac09ea0a fstab-util: introduce fstab_is_extrinsic()
- a20e4ea0ed device: drop refuse_after
- 2799fffac1 man: drop some left-over mentions of StandardOutput=syslog
- 144aff9c3b sd-netlink: remove unused RTNL_WQUEUE_MAX define
- 34ca8df8e1 test: Add return 0 to main() function (even it is not strictly necessary)
- 6e03f328a9 network: 'cur' variable cannot be null, so simplify code
- 8d0c97f6ca tree-wide: Initialize _cleanup_ variables if needed
- 4f174e49ae netlink: Fix assert condition on n_containers
- 3905ce532c journald: Increase stdout buffer size sooner, when almost full
- 5a37eb7c61 core: don't bind varlink socket if running in test mode
- 33fff72ce6 pam_systemd: also print debug lines when ending a session
- ba9af79ccb pam_systemd_home: use correct macro for converting ptr to fd
- 6199235489 Fix misuse of PAM_PROMPT_ECHO_OFF in systemd-homed
- c180a2c452 shared/ethtool-util: hush gcc warnings about array bounds
- 1addba4aac core: fix compilation with gcc -O3
- 9c46b97161 random-util: use ERRNO_IS_NOT_SUPPORTED() macro
- d85f9093d2 tmpfiles: clarify that "!" lines are filtered before collisions are checked
- 2fac966a5c man: mention the exclamation mark and minus sign literally, to make things searchable
- 4f61be3373 man: clarify that exit status name mappings are unaffected by SuccessExitStatus=
- b747d74a41 seccomp-util: add new syscalls from kernel 5.6 to syscall filter table
- c30d8caf8b tree-wide: Replace assert() by assert_se() when there is side effect
- b6e8e3be7e networkctl: use uint64_t for link speed throughout
- be66ce6089 tree-wide: use CMSG_SPACE() (and not CMSG_LEN()) to allocate control buffers
- 1cb197798a man: suffix pam options with "=" where arg is required too
- a5fe01d3da test: Use assert_se() where variables are only checked by assert
- 6960efd198 tree-wide: Fix, replace assert() by assert_se() when there is side effect
- 93c1b03074 tree-wide: Mark as _unused_ variables that are only used in assert()
- c7679d7a9f tree-wide: Workaround -Wnonnull GCC bug
- 073b257fd7 man: bring example PAM snippet of pam_systemd and pam_systemd_home back in sync
- 855291a81c man: highlight relevant lines in pam_systemd_home.so example PAM snippet
- f89ad7c0fd login: include pam_systemd_home.so in the default PAM snippet we ship for user@.service
- 9357f9466f test: Skip test-boot-timestamps on permission denied
- cad4ebe14e sysusers: be extra careful when locking accounts
- 551e6f233a shared/install: print name of offending file in error
- c6a2e51232 systemctl: fix --root support in querying presets
- 6f1eedbfdd systemctl: fix hint when 'systemctl help' is given
- 925521df7c shared/unit-file: fix resolution of absoulute symlinks with --root
- 756ba362e8 man: mention that ProtectSystem= also takes care of /efi
- 4f77cf43b5 man: systemd.service: systemd-analyze exit-codes -> exit-status
- 7c6ea7a053 man: expand on the star…end/repetition time expressions
- e06b940792 calendarspec: be more graceful with two kinds of calendar expressions
- f3dd0b476d calendarspec: minor simplification
- 3581c16d56 shutdown: fix spacing in shutdown error message
- 9556255349 nspawn: mount custom paths before writing to /etc
- 37447b7e78 repart: fix partition maximum size segfault
- 7f231ba503 link: Add units and fix typo in (Rx|Tx)BufferSize= manpage. Clean up the implementation slightly
- e75d2cdb0b main: bump RLIMIT_MEMLOCK by physical RAM size
- e16b9a1e31 nspawn: be more careful with creating/chowning directories to overmount
- 765d184a69 homectl: say "home area" in more places
- c11bff4fa7 userdbctl: make --help fit in 80 columns
- 0e56c2ef3f shell-completion/zsh: update systemd-analyze completions
- 2bb580f994 zsh: fix disable/enable completion
- 607a19a309 cgroup-util: check for SYSFS_MAGIC when detecting cgroup format
- ddb3c38efc stat-util: no need to open a file to check fs type
- bd8842304c sysusers,tmpfiles: always mention error when failing to replace specifiers
- bdea9b65d2 sysusers: add accidentally forgotten 'return'
- 17b059774d man: document binfmt's new --unregister switch
- 560380d8ec binfmt: also unregister binfmt entries from unit
- 80835d9c51 binfmt: modernize code a bit
- a1745741b8 shutdown: unregister all binfmt_misc entries before entering shutdown loop
- b637445950 shared: add common helper for unregistering all binfmt entries
- 0215625e99 home: fix strv NUL termination
- 038988baa1 networkd: don't do lldp rx nor tx on bond devices
- 9512d576d9 sd-bus: Fix typo in sd_bus_message_append_array docs
- 63cef71dd0 shared: add NULL callback check in one more place
- 6b91ca22a2 core: fix unused variable warning when !HAVE_SECCOMP
- f7c1c79c57 udev: prepare memory for extra NUL termination for NULSTR
- 69e0ef0d99 tree-wide: use recvmsg_safe() at various places
- cd0a84d4e9 socket-util: add recvmsg_safe() wrapper that handles MSG_CTRUNC
- 2bb48c704b sd-bus: work around ubsan warning
- c147bba1fb shared: Don't try calling NULL callback in bus_wait_for_units_clear
- f907491463 run: don't wait for start job to complete when running interactively anyway
- d3d1550a5d man: Fix typo "multiplied with" -> "multiplied by"
- ae5a9f27c5 core: make sure we don't get confused when setting TERM for a tty fd
- a07d3eaf76 man: document that VirtualEthernetExtra= has nothing to do with Bridge=
- 35fe81078e core: add debug log when a job in the activation queue is not runnable
- a0cd882be8 core: add log_get_max_level check optimization in log_unit_full
- 2a6ad1093c util: return the correct correct wd from inotify helpers
- 9ec244c5c1 core: minor error code handling fixes
- a799283c91 man: document how to get the boot menu with zero time-out
- 7263e86c8d resolved: return org.freedesktop.resolve1.DnsError.NXDOMAIN on LLMNR resolution failure
- 6eab4c2b3e man: use manpages.ubuntu.com for resolvconf(8) link
- 75ccec5cde man: add a note that resolvconf updates /etc/resolv.conf in specific circumstances
- 3e3a31743a resolvectl: fix indentation of hexdump'ed packets
- 6576058fab journald: add configuration option for enabling/disabling audit during journald startup
- 52c5909f15 man/systemd-service: clarify env variable expansion
- ac08df59c0 resolved: fix typo in an unused function and add comment
It seems nix is much more permissive in applying patches than git am.
These patches were regenerated by running
`git am path/to/nixpkgs/pkgs/os-specific/linux/systemd/*.patch`,
and manually running `patch -p1 < path/to/nixpkgs/pkgs/os-specific/linux/systemd/*N.patch`
where necessary.
After patching, this produces exactly the same source code as in our
custom fork, but having the actual patches inlined inside nixpkgs makes
it easier to get rid of them.
In case more complicated rebasing is necessary, maintainers can
- Clone the upstream systemd/systemd[-stable] repo
- Checkout the current rev mentioned in src
- Apply the patches from this folder via `git am 00*.patch`
- Rebase the repo on top of a new version
- Export the patch series via `git format-patch $newVersion`
- Update the patches = [ … ] attribute (if necessary)
Andreas Rammhold
Jörg Thalheim
Florian Klink