The version was bumped in #36081,
but the dependencies were not updated,
causing Vagrant to fail at runtime.
Fix the dependencies (via bundix),
and add an `installCheckPhase` to the derviation
to catch this in the future.
Don't default `doCheck` to false,
and use the default set of phases
so the phases list does not need to be overriden
in order to add checkPhase or installCheckPhase.
See the [changelog](a06e85f6ce/CHANGELOG (L1-L51)).
Changes to options:
- `withKeePassBrowser`: New in version 2.3.0 and replaces the
functionality provided by the KeePassHTTP plugin. Users should
install the
[KeePassXC-Browser extension](https://github.com/keepassxreboot/keepassxc-browser).
Defaults to `true` to remain consistent with the old default for
`withKeePassHTTP`.
- `withKeePassHTTP`: This feature is deprecated and disabled by default
in the source repository. Default changed from `true` to `false`.
- `withKeePassNetworking`: Controls all network access code within
KeePassXC. Defaults to `false` to match the source repository.
- `withKeePassSSHAgent`: Enables the SSH Agent plugin for use with
[KeeAgent](https://lechnology.com/software/keeagent/). Defaults to
`false` to match the source repository.
Prior to this change, desmume would fail to build due to an error:
utils/libfat/directory.cpp:142:33: error: ISO C++ forbids comparison between
pointer and integer [-fpermissive]
Based on a request by @oxij:
“Can we also rename this file to `maintainers/maintainers-list.nix` while we at
this? Motivation: much saner `git log ./lib`.”
Corrected every handle that had no commits to nixpkgs, manually researched the
correct handles by looking at maintained packages & blames/history on Github.
Based on https://github.com/NixOS/nixpkgs/pull/34842, the
nix-instantiate output was pretty-printed and the validity of the github handles
manually verified, by automatically checking whether the user handles exist on
github (https://github.com/userhandle, status 200 or 404).
Each handle under 5 characters was manually checked (because the collision
probability with non-maintainer accounts is high), each missing entry was
manually researched.
The script used is kept in `maintainers/scripts` as an example of how to work
with the mainainers list through nix’ JSON interface.
