This is less brittle and breaks loud if the code changes.
Also remove the /usr/bin/file patch. It is not really required
for the build to work, the generated warning is harmless.
* Replace LD_LIBRARY_PATH with OS-specific name (e.g. DYLD_LIBRARY_PATH
on macOS).
* Disable Python tests on macOS, because they use gpg, which fails due
to a very long socket path (https://github.com/NixOS/nix/pull/1085).
The former should be fixed upstream. The latter is a Nix-specific issue,
but it can be worked-around upstream by making Python tests respect
--disable-gpg-test.
* pythonPackages.matplotlib: add veprbl to maintainers
* pythonPackages.matplotlib: remove an old darwin hack
* pythonPackages.matplotlib: remove python and stdenv from buildInputs
* python3Packages.matplotlib: remove a hack for python33
* pythonPackages.matplotlib: remove outdated checkPhase
Downloading the baseline_images is not a real issue, building against
older freetype (local_freetype = True) is, perhaps, not what we
want. The good news is that the tests would pass (tested on 3.2.1) if
we were to enable them:
========== 6684 passed, 1332 skipped, 10 xfailed in 228.64s (0:03:48) ==========
* pythonPackages.matplotlib: provide setup.cfg from a file instead of a patch
* python3Packages.matplotlib: 3.1.3 -> 3.2.1
This caused none of these flags to have any effect. That's because
the configure command looked like this:
./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
--without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
with one giant flag '--without-test --without-contrib...', containing
internal spaces.
This can be seen in `nix log nixpkgs.gbsplay`, in this line:
configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
and then in the fact that features like "devdsp" and "midi" are listed
as enabled in later output, and source files like plugout_midi.c are
included in the build.
I don't have a real opinion on whether it's better to have these flags
or not, but it's clear the author's intention was to pass them. So,
fix the attr name so they get passed.
This is a better name since we have multiple 64-bit things that could
be referred to.
LP64 : integer=32, long=64, pointer=64
ILP64 : integer=64, long=64, pointer=64
