Jörg Thalheim
af652dd3d3
Merge pull request #94285 from Mic92/dependabot
...
dependabot: automatically update github actions
2020-07-31 06:11:54 +01:00
Jörg Thalheim
e2f49f7db8
dependabot: automatically update github actions
2020-07-31 06:02:53 +01:00
Jörg Thalheim
6dce0bb299
Revert "actions/editorconfig: disable until we can combine this with ofborg ( #88608 )"
...
This reverts commit 1ccf44204b
2020-07-30 21:45:29 +01:00
zowoq
e0742ab146
.github/workflows/wait-ofborg.yml: 260 -> 360
2020-07-29 11:38:18 +10:00
Jörg Thalheim
369f7dbc64
github-ci/ofborg: progress indicator
2020-07-28 15:06:32 +01:00
Jörg Thalheim
88c60d97fc
github-action/ofborg: only run in main repo
2020-07-28 14:52:09 +01:00
Jörg Thalheim
13f1c2386c
github-actions: increase timeout to wait for ofborg
2020-07-28 14:39:20 +01:00
Jörg Thalheim
4f95d1f259
add github action to wait for ofborg
...
In case ofborg is down this will not mark the CI as green.
Also if other github actions are used and pass
checks will be still marked as pending even if other other github
actions have passed.
2020-07-21 09:39:38 +01:00
Linus Heckemann
3ecbb6a817
stale bot: spelling nit
2020-07-17 08:22:12 +02:00
Doron Behar
29c538392c
stale-bot: Make it's messages more instructive
...
As somewhat discussed at: https://git.io/JJkRa , make the bot's message a
bit more instructive, and clearer as for what it will and won't do, so
random contributors will have a better idea what this is about.
Also: Split stale issues' and PRs' messages because each should
suggest different actions to do.
2020-07-04 23:13:28 +03:00
Marek Mahut
3c14632da2
CODEOWNERS: adding mmahut to blockchains
2020-06-20 17:03:37 +02:00
Graham Christensen
5d0725a063
Revert "Merge nixos-hardware into nixpkgs under /nixos/hardware"
2020-06-20 08:21:15 -04:00
Profpatsch
ba2dcbce23
nixos/hardware: move CODEOWNERS to toplevel
2020-06-20 13:05:20 +02:00
Ryan Mulligan
c516c31d16
.github/stale.yml: fix formatting
...
Before this, the message being written is:
```
Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:
1. Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
2. Ask on the [NixOS Discourse](https://discourse.nixos.org/ ). 3. Ask on the [#nixos channel](irc://irc.freenode.net/#nixos) on
[irc.freenode.net](https://freenode.net ).
```
Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
.github/stale.yml: fix newlines
2020-06-01 20:56:41 -07:00
zowoq
83ad0f5a99
.github/stale.yml: quote labels
2020-06-01 11:14:28 +10:00
Jörg Thalheim
1ccf44204b
actions/editorconfig: disable until we can combine this with ofborg ( #88608 )
...
We cannot run this check now, as it marks CI as green even though ofborg has not
evaluated it yet. In future we might be able to mark ofborg as a required test:
https://github.com/NixOS/nixpkgs/pull/87853#issuecomment-632676824
2020-05-22 13:15:13 +00:00
zowoq
05f9269602
editorconfig.yml: suppress curl output
2020-05-21 07:40:40 +10:00
zowoq
2f0c2d4c45
editorconfig.yml: switch to binary
2020-05-21 01:14:43 +10:00
zowoq
a42190fc07
GitHub Actions: check editorconfig in PRs
2020-05-20 20:24:33 +10:00
Elis Hirwing
3d3519e2c3
CODEOWNERS: Move code ownership to php maintainer team
2020-05-16 19:46:50 +02:00
zowoq
89b6d5f175
.github/CODEOWNERS: add podman team
2020-05-16 14:03:51 +10:00
Jan Tojnar
96f3c622af
github/CODEOWNERS: Add myself to updaters
2020-05-13 14:16:47 +02:00
Pavol Rusnak
7b0167204d
treewide: use https for nixos.org and hydra.nixos.org
...
tarballs.nixos.org is omitted from the change because urls from there
are always hashed and checked
2020-05-03 22:14:21 -07:00
Elis Hirwing
338205d61e
codeowners: Add etu as owner of php tests
2020-04-29 20:17:26 +02:00
Elis Hirwing
410c38f317
Revert "PHP maintainer team"
2020-04-29 19:56:37 +02:00
Elis Hirwing
3b21abb3d3
Merge pull request #85575 from etu/php-maintainer-team
...
PHP maintainer team
2020-04-29 19:56:03 +02:00
Jörg Thalheim
974d11d53f
Merge pull request #86110 from Mic92/pr-template
...
PULL_REQUEST_TEMPLATE: try to simplify call-for-review
2020-04-27 22:15:21 +01:00
Jörg Thalheim
93862d05f7
PULL_REQUEST_TEMPLATE: try to simplify call-for-review
...
The text is quite long and hard to read in hub (because it is one whole line
with no line breaks). Also simplified the language/sentence structure a bit for
non-native speakers.
2020-04-27 22:07:19 +01:00
Jörg Thalheim
c32c613df6
Merge pull request #85727 from davidak/patch-2
2020-04-27 10:36:12 +01:00
davidak
9c32e5c495
CONTRIBUTING.md: Improve backport instructions
2020-04-26 19:35:13 +02:00
Silvan Mosberger
16f0335d3f
.github/CODEOWNERS: Remove myself as codeowner from some paths
...
It's a bit too spammy!
2020-04-23 16:21:28 +02:00
Elis Hirwing
4b436226cf
codeowners: Add etu as owner of php tests
2020-04-22 06:48:07 +02:00
worldofpeace
e9e9582986
Merge pull request #85186 from worldofpeace/20.03-readme
...
README.md: 20.03 release
2020-04-20 11:57:45 -04:00
worldofpeace
a045b050dc
CONTRIBUTING.md: 20.03
2020-04-14 09:55:55 -04:00
worldofpeace
29efd1e6a4
bug_report.md: ask to notify maintainers
...
This is really essential thing that everyone should be doing.
A few extra notifications won't hurt anyone, and we should be tracking issues
to connect them to the best people who can handle them.
Co-Authored-By: Cole Helbling <cole.e.helbling@outlook.com>
2020-04-13 18:03:05 -04:00
Elis Hirwing
3b6539896b
Merge pull request #83896 from etu/slim-down-default-php-v3
...
PHP: Make the default package more sane [v3]
2020-04-05 20:00:03 +02:00
Elis Hirwing
e4cee802ad
doc/php: Add initial documentation for PHP
2020-04-05 16:45:04 +02:00
zimbatm
5e37578dd9
.github/CODEOWNERS: remove myself from it
...
ofborg does a better job at assigning people
2020-04-01 13:05:38 +02:00
Bas van Dijk
de8bc79c42
.github/CODEOWNERS: remove myself from the Haskell code owners
2020-02-21 10:01:41 +01:00
Profpatsch
7f3091f26a
CODEOWNERS: add lassulus and Profpatsch to build-support/writers
2020-02-18 19:59:48 +01:00
Mario Rodas
0e4a7d9f25
Merge pull request #77806 from softinio/update-codeowners
...
Add myself as vim plugins codeowner
2020-01-29 02:51:17 -05:00
Profpatsch
6841f408cc
CODEOWNERS: add Profpatsch to /lib/cli.nix and /lib/asserts.nix
2020-01-23 14:47:38 +01:00
Salar Rahmanian
9aff6191b0
Add myself as vim plugins codeowner
2020-01-15 22:56:54 -08:00
Leonhard Markert
d6a9898771
CONTRIBUTING.md: add section "Backporting changes"
2020-01-13 15:33:16 +01:00
Lassulus
773494d0ea
Merge pull request #70208 from mrVanDalo/feature/pull-request-workflow
...
doc : improve and cleanup of submitting-changes
2020-01-10 10:06:55 +01:00
Andreas Rammhold
71a96b28a0
CODEOWNERS: add myself to pkgs/build-support/rust
2020-01-07 11:57:34 +01:00
Eelco Dolstra
1d59cdcb2a
ISSUE_TEMPLATE: 'nix run' -> 'nix-shell -p'
...
'nix run' is an experimental command.
2020-01-05 22:47:43 +01:00
Ingolf Wagner
d9bbc22cef
.github: remove cc from pull-request template
2020-01-03 15:58:31 +13:00
Silvan Mosberger
43e1c6e352
codeowners: Add infinisil to some more paths
2020-01-01 03:01:48 +01:00
Jörg Thalheim
8a57552c18
nixpkgs-review: 2.1.0 -> 2.1.1
...
changelog: https://github.com/Mic92/nixpkgs-review/releases/tag/2.1.1
2019-12-22 09:26:57 +00:00
David Kleuker
cc4447dab4
Update CONTRIBUTING.md
...
to reflect the introduction of issue templates
2019-12-04 15:30:56 +01:00
Jacek Galowicz
faaf95ff69
codeowners: add tfc as test-driver owner
2019-11-25 18:02:48 +01:00
Aaron Andersen
4143b6ae0b
codeowners: add etu as php owner
2019-11-22 07:20:47 -05:00
Ryan Mulligan
dc4339dc26
Add configuration for GitHub stale bot
...
The configuration added is taken from RFC 0051, and is the first step
toward implementing it. Next, we will have to enable the stale bot by
installing the GitHub application.
https://github.com/NixOS/rfcs/blob/master/rfcs/0051-mark-stale-issues.md
2019-11-14 22:11:32 -08:00
Jonathan Ringer
4c810e70ef
codeowners: add jonringer as vimplugin and vscode ext owner
2019-10-30 21:49:23 -07:00
Americo
5c59da48e4
.github: clarify things done re: sandboxing
...
Per https://github.com/NixOS/nixpkgs/pull/58147#issuecomment-478234495
sandboxing is not fully functional on macOS.
.github: specify where sandboxing can be run
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
.github: remove macOS note
2019-10-30 11:32:29 -07:00
Vladimír Čunát
3c5f5b1cde
Fix link in PULL_REQUEST_TEMPLATE.md (the same link)
2019-10-28 19:25:05 +01:00
David Kleuker
bdc3697b8e
Fix link in CONTRIBUTING.md
2019-10-28 19:25:05 +01:00
Jonathan Ringer
aed81020ed
codeowners: add jonringer as python packages codeowner
2019-10-18 23:56:59 -07:00
(cdep)illabout
d10b6bde34
codeowners: add cdepillabout to CODEOWNERS for Haskell-related packages
...
This commit adds myself as a CODEOWNER for the Haskell-related packages.
2019-09-13 16:02:35 +09:00
Austin Seipp
0aee12e0b3
CODEOWNERS: add myself as owner of ntp packages
...
Signed-off-by: Austin Seipp <aseipp@pobox.com>
2019-09-12 11:45:51 -05:00
WilliButz
82b7e9baf3
CODEOWNERS: add myself for prometheus exporters
2019-09-12 12:48:40 +02:00
adisbladis
d20d6034bd
CODEOWNERS: Add myself as owner for emacs
2019-08-30 17:23:13 +01:00
Peter Simons
8c7c18992f
CODEOWNERS: add myself as a reviewer for mail/dns related NixOS modules
2019-08-30 14:46:20 +02:00
Steven Shaw
e2a28e8dd2
PULL_REQUEST_TEMPLATE: Add "Notify maintainers" section
2019-07-30 08:36:16 +02:00
zimbatm
2a227c6cd8
.github/ISSUE_TEMPLATE/security.md: remove
...
since the .github/SECURITY.md was added in the org-level repo, there are
now two entries in the list. So remove this-one.
2019-07-26 15:33:26 +02:00
zimbatm
2797ddee7d
Remove .github/FUNDING.yml
...
The configuration is now done through the shared configuration repo:
https://github.com/nixos/.github
2019-07-23 15:19:40 +02:00
zimbatm
5cece63aad
github: use the new issue template ( #64983 )
...
Create new categories for the issues:
* Bug report
* Packaging request
* Security
Add metadata information to the issues so that we may match issues to
maintainers using a bot in the future.
The old `.github/ISSUE_TEMPLATE.md` is being used by the "Open a regular
issue." link.
2019-07-22 09:04:00 +00:00
Alyssa Ross
265d3bc1d6
CODEOWNERS: add myself for lib/licenses.nix
...
There have been a couple of instances where I have by chance noticed PRs
which add non-free licenses without them being appropriately marked. I'd
like to be notified of proposed changes to licenses to make it less
likely that this sort of thing slips by.
2019-07-20 14:08:46 +02:00
Domen Kožar
8a2b829b15
Update FUNDING.yml
2019-07-17 14:22:24 +02:00
Craig Hall
d096030d07
PULL_REQUEST_TEMPLATE: "Assured whether" -> "Ensured that"
2019-07-01 11:22:48 +01:00
worldofpeace
f6d2ebe313
Add .github/FUNDING.yml
2019-05-31 22:15:17 -04:00
Silvan Mosberger
f1dc49171f
CODEOWNERS: Change me from all NixOS modules to just new ones
2019-05-01 20:32:02 +02:00
Joachim Fasting
344b86f1f0
CODEOWNERS: add myself to files related to the hardened profile
...
I'm listed as the maintainer for most of these already but would like to be
notified on changes.
2019-04-18 16:49:53 +02:00
worldofpeace
1d38a2f5c3
Merge pull request #58098 from Infinisil/encouraging_reviews
...
PULL_REQUEST_TEMPLATE: Add encouragement to review PRs
2019-04-04 17:14:18 -04:00
Peter Simons
cfaca4814b
CODEOWNERS: I'd rather not review Haskell PRs any more
2019-03-30 15:38:28 +01:00
Silvan Mosberger
4e398a325e
PULL_REQUEST_TEMPLATE: Add encouragement to review PRs
2019-03-28 21:18:46 +01:00
Jörg Thalheim
22d083e659
doc/reviewing-contributions: nix-review instead of nox-review
...
It is faster, handles more edge cases and allows to test/review the built
packages interactively.
2019-03-20 11:28:00 +00:00
Ryan Mulligan
afa525bff9
.github/CODEOWNERS: remove @ryantm from haskell
...
I'm happy to keep helping out with Haskell infrastructure where I can,
but I don't have a good system for handling the accidental codeowner
pings caused by target branch switches.
2019-02-28 21:32:35 -08:00
Frederik Rietdijk
92def1d5f7
codeowners: fix reference to renamed file
2018-12-26 10:42:11 +01:00
volth
a0838372b7
CODEOWNERS: add @volth to Perl
2018-12-21 02:37:39 +00:00
Alyssa Ross
ce66baaf71
CODEOWNERS: add @alyssais (me) to Ruby
2018-12-20 14:29:32 +00:00
Niklas Hambüchen
f2816e47ab
PULL_REQUEST_TEMPLATE: Ask for docs
2018-11-22 19:57:19 +01:00
Philip Patsch
75e357e210
CODEOWNERS: add mboes and Profpatsch for bazel packaging
...
There is an elevated commercial interest of keeping the bazel
ecosystem up-to-date, Tweag I/O takes on maintainership.
2018-11-21 12:06:44 +01:00
Silvan Mosberger
25864ec2b7
Merge pull request #50183 from Infinisil/idris-codeowners
...
.github/CODEOWNERS: Add infinisil to idris-modules
2018-11-14 19:19:55 +01:00
Silvan Mosberger
f37d3a463d
.github/CODEOWNERS: Add infinisil to idris-modules
2018-11-10 16:12:36 +01:00
Silvan Mosberger
90ad9dc646
.github/CODEOWNERS: Add infinisil to NixOS modules
2018-11-10 14:00:04 +01:00
Profpatsch
34bf218b16
Add dhallPackages and add current Prelude
...
Dhall is a non-turing complete programming language.
2018-11-04 16:43:41 +01:00
Matthew Bauer
791e98eb90
Add myself to a few CODEOWNERS paths
2018-11-02 19:07:08 -05:00
Austin Seipp
6a0e8c2738
.github/CODEOWNERS: add myself as the PostgreSQL owner
...
Since the development of #38698 , I have been radically overhauling the
PostgreSQL support and plan on maintaining it in the long run, taking
over from @ocharles, who authored most of it initially.
However, while #38698 has not been merged (yet), I'm taking the time to
go ahead and add myself as the owner of all the related code, so that I
can be marked as a reviewer for things people submit in the mean time.
Signed-off-by: Austin Seipp <aseipp@pobox.com>
2018-11-02 09:29:36 -05:00
c74d
e74c7666c7
CONTRIBUTING.md: Clarify clarification on periods
...
Commit 9428c28f7a
2018-10-10 21:06:12 +00:00
joncojonathan
9428c28f7a
CONTRIBUTING.md: add clarification on periods in commit messages
2018-10-08 21:26:12 +01:00
Ryan Mulligan
5c5baaf17d
treewide: remove mailing list references
2018-08-23 09:24:44 -07:00
John Ericson
af36123747
.github/CODEOWNERS: Add myself as for some stdenv stuff
2018-08-11 13:57:53 -04:00
Bas van Dijk
5fe904b7ec
.github/CODEOWNERS: add basvandijk to Haskell
2018-07-23 12:52:22 +02:00
Ryan Mulligan
8d3c12d9c3
.github/CODEOWNERS: add ryantm to Haskell
2018-07-21 07:47:33 -07:00
Ryan Mulligan
940094a0d5
.github/CODEOWNERS: remove tabs
2018-07-21 07:46:52 -07:00
Eelco Dolstra
bf1c28e978
PULL_REQUEST_TEMPLATE.md: Ask for closure size impact
2018-06-21 18:52:26 +02:00
Bob van der Linden
b503e76ee0
use sandbox instead of build-use-sandbox
2018-05-30 21:48:07 +02:00
Frederik Rietdijk
51556f640d
FRidh as owner of update-python-libraries
2018-05-28 14:21:30 +02:00
Profpatsch
06156610f1
CODEOWNERS: add Profpatsch to lib/debug.nix
...
Reason: has overhauled the module quite substantially.
2018-04-27 18:59:39 +02:00
Jörg Thalheim
ed453ccb9c
CODEOWNERS: add Mic92/LnL7 for rustc
...
Mic92: linux-x86_64, linux-aarch64
LnL7: for macOS-x86_64
2018-04-09 14:47:10 +01:00
Profpatsch
99f2b33519
CODEOWNERS: Add Profpatsch to /lib/generators.nix
...
I’d like to be notified of changes so I can ensure the API always follows the same patterns.
Later (more specific) files replace more general codeowners [according to the documentation](https://help.github.com/articles/about-codeowners/ ), so I also listed `edolstra` and `nbp` again.
2018-03-24 13:35:41 +00:00
Matthew Bauer
124d47c65a
meta: fix fallout from #36275
2018-03-18 00:16:43 -05:00
John Ericson
98ede1e2ae
CODEOWNERS: Make @orivej a {cc,bintools}-wrapper codeowner
2018-01-19 16:18:27 -05:00
Eelco Dolstra
6060a6dd22
CODEOWNERS cleanup
...
I haven't worked on stdenv etc. in a long time.
2018-01-19 18:41:32 +01:00
John Ericson
cada00bc49
CODEOWNERS: Add me, @Ericson2314, to a few things
2017-12-18 19:00:43 -05:00
Thomas Tuegel
13a0433773
CODEOWNERS: Add ttuegel for Qt / KDE
2017-12-07 13:44:10 -06:00
Yegor Timoshenko
f74945755a
CODEOWNERS: exclude lib/licenses.nix
2017-11-16 20:27:16 +00:00
Orivej Desh
737e415820
Merge pull request #31534 from yegortimoshenko/patch-7
...
CODEOWNERS: exclude lib/maintainers.nix
2017-11-16 20:11:22 +00:00
Graham Christensen
cec203be16
ISSUE_TEMPLATE: replace technical details withh nix-info
2017-11-13 20:44:52 -05:00
Joerg Thalheim
0533e56671
CONTRIBUTING.md: be more precise what is meant by formatting commits
2017-11-13 09:05:18 +00:00
Yegor Timoshenko
fa9d4a3ef3
CODEOWNERS: exclude lib/maintainers.nix
...
Resolves #31401 .
2017-11-11 18:44:31 +00:00
zimbatm
088ce9f23f
CODEOWNERS: fix path notation
...
This format uses the path matching algorithm as the .gitignore format.
The paths need to be prefixed with a / to become absolute, otherwise it
will match all of these files.
The paths will also match any of the sub-paths by default so it's not
necessary to use the `*` like in bash globbing.
2017-11-01 19:05:17 +00:00
Nicolas B. Pierron
e2f8fa37f2
Flag my-self as owner of Nixpkgs and NixOS internals
2017-11-01 11:48:35 +01:00
zimbatm
4a4f6ba418
CODEOWNERS: fix path matching
2017-10-30 15:20:54 +00:00
zimbatm
abbea503b9
CODEOWNERS: add zimbatm to ruby modules
2017-10-30 15:13:47 +00:00
Joachim F
37acc1a5df
Merge pull request #29668 from vyp/doc/contributing.md
...
CONTRIBUTING.md: mention that the meta.license and meta.maintainers attributes must be set
2017-10-28 11:14:15 +00:00
Matthew Justin Bauer
b28bd2a81f
Update CODEOWNERS to use darwin-maintainers team
...
This sets up the Darwin-maintainers team as CODEOWNERS for Darwin paths. So anyone in that team will get notified (instead of just listing individuals).
/cc @org/darwin-maintainers
2017-10-12 00:38:18 -05:00
Maxime Dénès
9ca1b56683
pr template: make values of platform field less ambiguous
2017-10-09 12:53:09 +02:00
xd1le
4b25ecc7b8
CONTRIBUTING.md: license should default to unfree if there is no
...
upstream license
2017-10-09 20:37:02 +11:00
Robert Helgesson
51b557b2c8
CODEOWNERS: add @rycee for Eclipse IDE
2017-10-05 22:43:07 +02:00
xd1le
306a0d32df
CONTRIBUTING.md: mention that the meta.license and meta.maintainers
...
attributes must be set
2017-09-22 23:12:49 +10:00
Edward Tjörnhammar
d623220b78
CODEOWNERS: jetbrains
2017-09-19 10:26:29 +02:00
Profpatsch
4cbe7bda70
Remove Profpatsch from the CODEOWNERS file
...
Since CODEOWNERS shall be interpreted as actual ownership (and not just a
mentionbot replacement), I will remove myself again.
2017-09-13 19:56:13 +02:00
Gleb Peregud
c041770f2c
Add gleber to CODEOWNERs of beam-related packages.
2017-09-11 23:03:49 +02:00
Eelco Dolstra
24646266bb
Set ownership of CODEOWNERS
2017-09-07 12:19:54 +02:00
Eelco Dolstra
adb8a0a7e1
Change owner of stdenv and lib
2017-09-07 12:17:36 +02:00
Peter Simons
b1ca0f465f
CODEOWNERS: (align-regexp "@") my code blocks
2017-09-07 09:07:40 +02:00
Peter Simons
88d11c4e4b
CODEOWNERS: tabs are evil
2017-09-07 09:06:01 +02:00
Peter Simons
a95c577038
CODEOWNERS: add peti for R-related code
2017-09-07 09:04:30 +02:00
Peter Simons
baf9dfc476
CODEOWNERS: add peti for Haskell-related code
2017-09-07 09:04:26 +02:00
Profpatsch
6afa844d31
CODEOWNERS: add Profpatsch to various paths
2017-09-07 04:29:55 +02:00
Piotr Bogdan
e221d945ad
pr template: make formatting consistent
2017-09-03 19:57:18 +01:00
Dmitry Kalinkin
b6a1e439e1
documentation: use modern Firefox version in example
2017-09-01 14:03:28 -04:00
Linus Heckemann
02d168e130
Pull request template: comment out instructions
2017-08-12 15:17:39 +01:00
John Ericson
9b10fcce2f
Add myself to CODEOWNERS, and use tab consistently
2017-07-31 19:38:16 -04:00
Frederik Rietdijk
8977bee504
Merge pull request #27499 from FRidh/codeowners
...
CODEOWNERS file for review requests
2017-07-30 08:11:11 +02:00
Yegor Timoshenko
72239c3a22
PULL_REQUEST_TEMPLATE.md: mereley -> merely
2017-07-28 23:38:25 +00:00
Frederik Rietdijk
5414e2ae8d
CODEOWNERS file for review requests
...
Some time ago GitHub introduced the CODEOWNERS file. The file is similar
to the MAINTAINERS file that was proposed in
https://github.com/NixOS/nixpkgs/issues/13602 . Code owners will
automatically receive a review request.
2017-07-28 15:04:48 +02:00
Frederik Rietdijk
138eba0bff
Pull request template: clarify the purpose of the template
2017-07-22 18:05:16 +02:00
Bjørn Forsman
8537cf0f81
CONTRIBUTING.md: suggest "nixos/<module>" prefix for NixOS changes
...
Suggest prefixing commit messages that touches NixOS code with
"nixos/<module>" instead of the current "<name> service" prefix.
"<name> service" is limiting in that NixOS code is more than the
services. It is also easier to spot NixOS changes with explicit
"nixos/..." prefix.
2017-07-22 00:21:05 +02:00
aszlig
fa6fd34fcc
github/pr-template: Add note about NixOS tests
...
On several occasions I've seen people bumping packages which have NixOS
tests but without actually running them.
While this probably won't prevent such occasions entirely, at least it
serves as an additional checklist item so contributors don't forget
about these tests.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
2017-06-23 05:33:06 +02:00
Alexey Shmalko
f5bed28db8
github issue template: add sandboxing info
2017-05-01 15:38:11 +03:00
Hannu Hartikainen
9ed8627a76
CONTRIBUTING.md: improve commit message guidelines
...
Add a brief request for expressing the motivation for a change. Change the example commit messages to match.
Resolves #19126 .
2017-02-06 22:26:32 +02:00
Vladimír Čunát
b59167ce0e
CONTRIBUTING.md: switch to a link that actually works
...
Fixes #20594 .
2016-11-24 10:01:16 +01:00
Ignat Loskutov
d91eba4ec3
Update PULL_REQUEST_TEMPLATE.md
...
Follow the rebranding of OS X into macOS
2016-11-04 18:49:40 +03:00
zimbatm
0e3e7a6bcd
Merge pull request #18972 from ericsagnes/doc/reviewing-contributions
...
[WIP] nixos-doc: add reviewing contributions chapter
2016-10-01 15:09:12 +01:00
Eric Sagnes
7ad26bdc6e
improvements from feedback
2016-09-28 11:05:22 +09:00
Eric Sagnes
8d656d2ca0
nixos-doc: add reviewing-contributions
2016-09-26 15:44:06 +09:00
Wink Saville
0f386457e3
Update broken link in CONTRIBUTING.md
...
The current link returns a 404 error
2016-09-23 16:33:47 -07:00
Rushmore Mushambi
0192777972
PULL_REQUEST_TEMPLATE: rename chroot to sandbox
...
See b39622a487
2016-09-02 21:41:43 +02:00
Vladimír Čunát
156105c489
PR template: go back to old option name for now
...
The old one works on all nix(os) versions, whereas the new one doesn't
work e.g. on default 16.03 setting. Discussed on #15112 .
2016-06-29 21:44:05 +02:00
Daniel Peebles
0bd54a6d5d
Update PR template with motivation for changes
...
I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
2016-05-24 07:59:46 -04:00
Vladimír Čunát
4c10d404e7
github PR template: reformulate the sandboxing help
...
It's been reported that when running through nix daemon,
sandboxing can't be turned on by passing `--option` (silently ignored),
so let's not suggest that way.
https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-26 09:18:15 +02:00
Vladimír Čunát
7cf8daa2bb
nixos: rename chroot* to sandbox*
...
On Nix side this was done months ago:
https://github.com/NixOS/nix/pull/682
2016-04-25 11:04:08 +02:00
zimbatm
3b33c3628a
fixup! Simplify contributing
2016-04-09 20:51:26 +01:00
zimbatm
8706726d59
Simplify contributing
...
* Highlight the top mistakes directly in CONTRIBUTING.md
* Remove unecessary cruft from the PR template
2016-04-09 17:59:35 +01:00
Jakob Gillich
0d091ffd4a
simplify ISSUE_TEMPLATE
2016-03-31 16:14:54 +02:00
Nathan Zadoks
d0b8080062
.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes
2016-03-16 09:46:05 +01:00
Domen Kožar
2af46e4393
PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406
2016-02-28 09:26:28 +00:00
Domen Kožar
3c84ae406d
PULL_REQUEST_TEMPLATE.md: clarify a few things
2016-02-28 08:50:33 +00:00
Eelco Dolstra
830c2d6389
ISSUE_TEMPLATE.md: Tweak
2016-02-23 17:06:55 +01:00
Domen Kožar
71c231e2a6
Merge pull request #13388 from spacefrogg/contributing-fix
...
CONTRIBUTING.md: Fix link to COPYING
2016-02-23 14:07:19 +00:00
Michael Raitza
d53fa9884b
CONTRIBUTING.md: Fix link to COPYING
2016-02-23 13:50:01 +00:00
zimbatm
4ba3c96431
.github/ISSUE_TEMPLATE.md - get more information
...
The goal is to get all the necessary information from the reporter upfront.
Too many times the issues submits and we need to do a round of asking before
we can get close to a solution.
2016-02-23 12:09:41 +00:00
Arseniy Seroka
e4d0811c8b
Merge pull request #13100 from jagajaga/improvements
...
PULL_REQUEST_TEMPLATE: init
2016-02-22 13:47:34 +03:00
Arseniy Seroka
ac9ab2c3f5
PULL_REQUEST_TEMPLATE: init
2016-02-22 13:45:56 +03:00
Eelco Dolstra
88f5d1c8ba
Move CONTRIBUTING.md to .github
...
See https://github.com/blog/2111-issue-and-pull-request-templates .
2016-02-19 10:59:38 +01:00
