From 9191f09c0569821e11f9a7f0c552e794087a8163 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 01:59:52 +0100 Subject: [PATCH 01/11] network-manager/pptp: replace patch by substitutions to simplify upgrades --- .../network-manager/pptp-purity.patch | 26 ------------------- .../tools/networking/network-manager/pptp.nix | 17 ++++++------ 2 files changed, 9 insertions(+), 34 deletions(-) delete mode 100644 pkgs/tools/networking/network-manager/pptp-purity.patch diff --git a/pkgs/tools/networking/network-manager/pptp-purity.patch b/pkgs/tools/networking/network-manager/pptp-purity.patch deleted file mode 100644 index 88af666b6580..000000000000 --- a/pkgs/tools/networking/network-manager/pptp-purity.patch +++ /dev/null @@ -1,26 +0,0 @@ -diff --git a/src/nm-pptp-service.c b/src/nm-pptp-service.c -index 68a5759..568bbfe 100644 ---- a/src/nm-pptp-service.c -+++ b/src/nm-pptp-service.c -@@ -730,9 +730,7 @@ nm_find_pppd (void) - { - static const char *pppd_binary_paths[] = - { -- "/sbin/pppd", -- "/usr/sbin/pppd", -- "/usr/local/sbin/pppd", -+ "@ppp@/sbin/pppd", - NULL - }; - -@@ -752,9 +750,7 @@ nm_find_pptp (void) - { - static const char *pptp_binary_paths[] = - { -- "/sbin/pptp", -- "/usr/sbin/pptp", -- "/usr/local/sbin/pptp", -+ "@pptp@/sbin/pptp", - NULL - }; - diff --git a/pkgs/tools/networking/network-manager/pptp.nix b/pkgs/tools/networking/network-manager/pptp.nix index 1b1cf69119e4..12f28d840edd 100644 --- a/pkgs/tools/networking/network-manager/pptp.nix +++ b/pkgs/tools/networking/network-manager/pptp.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, networkmanager, pptp, ppp, intltool, pkgconfig, substituteAll +{ stdenv, fetchurl, networkmanager, pptp, ppp, intltool, pkgconfig , libsecret, withGnome ? true, gnome3 }: stdenv.mkDerivation rec { @@ -17,18 +17,19 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ intltool pkgconfig ]; + postPatch = '' + sed -i -e 's%"\(/usr/sbin\|/usr/pkg/sbin\|/usr/local/sbin\)/[^"]*",%%g' ./src/nm-pptp-service.c + + substituteInPlace ./src/nm-pptp-service.c \ + --replace /sbin/pptp ${pptp}/bin/pptp \ + --replace /sbin/pppd ${ppp}/bin/pppd + ''; + configureFlags = if withGnome then "--with-gnome --with-gtkver=3" else "--without-gnome"; postConfigure = "sed 's/-Werror//g' -i Makefile */Makefile"; - patches = - [ ( substituteAll { - src = ./pptp-purity.patch; - inherit ppp pptp; - }) - ]; - meta = { description = "PPtP plugin for NetworkManager"; inherit (networkmanager.meta) maintainers platforms; From b7731e446ac77653446d0ca7b953ea4264b3ad1b Mon Sep 17 00:00:00 2001 From: obadz Date: Tue, 21 Jun 2016 03:14:02 +0100 Subject: [PATCH 02/11] network-manager/l2tp: replace patch by substitutions to simplify upgrades --- .../network-manager/l2tp-purity.patch | 26 -------------- .../tools/networking/network-manager/l2tp.nix | 35 +++++++++---------- 2 files changed, 17 insertions(+), 44 deletions(-) delete mode 100644 pkgs/tools/networking/network-manager/l2tp-purity.patch diff --git a/pkgs/tools/networking/network-manager/l2tp-purity.patch b/pkgs/tools/networking/network-manager/l2tp-purity.patch deleted file mode 100644 index c9117c5325b6..000000000000 --- a/pkgs/tools/networking/network-manager/l2tp-purity.patch +++ /dev/null @@ -1,26 +0,0 @@ -diff --git a/src/nm-l2tp-service.c b/src/nm-l2tp-service.c -index d2c9dc4..e61d3d2 100644 ---- a/src/nm-l2tp-service.c -+++ b/src/nm-l2tp-service.c -@@ -655,9 +655,7 @@ nm_find_ipsec (void) - { - static const char *ipsec_binary_paths[] = - { -- "/sbin/ipsec", -- "/usr/sbin/ipsec", -- "/usr/local/sbin/ipsec", -+ "@strongswan@/bin/ipsec", - NULL - }; - -@@ -677,9 +675,7 @@ nm_find_l2tpd (void) - { - static const char *l2tp_binary_paths[] = - { -- "/sbin/xl2tpd", -- "/usr/sbin/xl2tpd", -- "/usr/local/sbin/xl2tpd", -+ "@xl2tpd@/bin/xl2tpd", - NULL - }; - diff --git a/pkgs/tools/networking/network-manager/l2tp.nix b/pkgs/tools/networking/network-manager/l2tp.nix index 3b06bf4524a1..fa349aa44c3d 100644 --- a/pkgs/tools/networking/network-manager/l2tp.nix +++ b/pkgs/tools/networking/network-manager/l2tp.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchFromGitHub, substituteAll, automake, autoconf, libtool, intltool, pkgconfig +{ stdenv, fetchFromGitHub, automake, autoconf, libtool, intltool, pkgconfig , networkmanager, ppp, xl2tpd, strongswan , withGnome ? true, gnome3 }: @@ -8,9 +8,9 @@ stdenv.mkDerivation rec { version = "0.9.8.7"; src = fetchFromGitHub { - owner = "seriyps"; - repo = "NetworkManager-l2tp"; - rev = version; + owner = "seriyps"; + repo = "NetworkManager-l2tp"; + rev = version; sha256 = "07gl562p3f6l2wn64f3vvz1ygp3hsfhiwh4sn04c3fahfdys69zx"; }; @@ -19,30 +19,29 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ automake autoconf libtool intltool pkgconfig ]; - configureScript = "./autogen.sh"; + postPatch = '' + sed -i -e 's%"\(/usr/sbin\|/usr/pkg/sbin\|/usr/local/sbin\)/[^"]*",%%g' ./src/nm-l2tp-service.c + + substituteInPlace ./src/nm-l2tp-service.c \ + --replace /sbin/ipsec ${strongswan}/bin/ipsec \ + --replace /sbin/xl2tpd ${xl2tpd}/bin/xl2tpd + + # Workaround https://github.com/xelerance/xl2tpd/issues/108 + substituteInPlace ./src/nm-l2tp-service.c --replace 'write_config_option (pppopt_fd, "lock\n");' "" + ''; + + preConfigure = "./autogen.sh"; configureFlags = if withGnome then "--with-gnome" else "--without-gnome"; postConfigure = "sed 's/-Werror//g' -i Makefile */Makefile"; - patches = - [ ( substituteAll { - src = ./l2tp-purity.patch; - inherit xl2tpd strongswan; - }) - ]; - - # Workaround https://github.com/xelerance/xl2tpd/issues/108 - postPatch = '' - substituteInPlace ./src/nm-l2tp-service.c --replace 'write_config_option (pppopt_fd, "lock\n");' "" - ''; - meta = with stdenv.lib; { description = "L2TP plugin for NetworkManager"; inherit (networkmanager.meta) platforms; homepage = https://github.com/seriyps/NetworkManager-l2tp; license = licenses.gpl2; - maintainers = with maintainers; [ abbradar ]; + maintainers = with maintainers; [ abbradar obadz ]; }; } From 925fb7ebfc7ed543866d8c0f0760af16821ebea5 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 02:34:58 +0100 Subject: [PATCH 03/11] network-manager: move 0.9.8 to its own directory --- .../networking/network-manager/{0.9.8.nix => 0.9.8/default.nix} | 0 .../networking/network-manager/{ => 0.9.8}/libnl-3.2.25.patch | 0 .../networking/network-manager/{ => 0.9.8}/nixos-purity.patch | 0 pkgs/top-level/all-packages.nix | 2 +- 4 files changed, 1 insertion(+), 1 deletion(-) rename pkgs/tools/networking/network-manager/{0.9.8.nix => 0.9.8/default.nix} (100%) rename pkgs/tools/networking/network-manager/{ => 0.9.8}/libnl-3.2.25.patch (100%) rename pkgs/tools/networking/network-manager/{ => 0.9.8}/nixos-purity.patch (100%) diff --git a/pkgs/tools/networking/network-manager/0.9.8.nix b/pkgs/tools/networking/network-manager/0.9.8/default.nix similarity index 100% rename from pkgs/tools/networking/network-manager/0.9.8.nix rename to pkgs/tools/networking/network-manager/0.9.8/default.nix diff --git a/pkgs/tools/networking/network-manager/libnl-3.2.25.patch b/pkgs/tools/networking/network-manager/0.9.8/libnl-3.2.25.patch similarity index 100% rename from pkgs/tools/networking/network-manager/libnl-3.2.25.patch rename to pkgs/tools/networking/network-manager/0.9.8/libnl-3.2.25.patch diff --git a/pkgs/tools/networking/network-manager/nixos-purity.patch b/pkgs/tools/networking/network-manager/0.9.8/nixos-purity.patch similarity index 100% rename from pkgs/tools/networking/network-manager/nixos-purity.patch rename to pkgs/tools/networking/network-manager/0.9.8/nixos-purity.patch diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 11570da0342d..0303a61fa8c6 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -2585,7 +2585,7 @@ in netselect = callPackage ../tools/networking/netselect { }; # stripped down, needed by steam - networkmanager098 = callPackage ../tools/networking/network-manager/0.9.8.nix { }; + networkmanager098 = callPackage ../tools/networking/network-manager/0.9.8 { }; networkmanager = callPackage ../tools/networking/network-manager { }; From 233541a3712dea8825d58ead2b00b4d8724e442f Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 01:40:18 +0100 Subject: [PATCH 04/11] network-manager: 1.0.12 -> 1.2.2 --- .../networking/network-manager/default.nix | 50 +++++++++---------- .../network-manager/nm-platform.patch | 17 ------- 2 files changed, 24 insertions(+), 43 deletions(-) delete mode 100644 pkgs/tools/networking/network-manager/nm-platform.patch diff --git a/pkgs/tools/networking/network-manager/default.nix b/pkgs/tools/networking/network-manager/default.nix index 34506cb823d0..5b1d56c0184c 100644 --- a/pkgs/tools/networking/network-manager/default.nix +++ b/pkgs/tools/networking/network-manager/default.nix @@ -5,12 +5,14 @@ , ethtool, gnused, coreutils, file, inetutils }: stdenv.mkDerivation rec { - name = "network-manager-${version}"; - version = "1.0.12"; + name = "network-manager-${version}"; + pname = "NetworkManager"; + major = "1.2"; + version = "${major}.2"; src = fetchurl { - url = "mirror://gnome/sources/NetworkManager/1.0/NetworkManager-${version}.tar.xz"; - sha256 = "17jan0g5jzp8mrpklyacwdgnnw016m1c5pc4az5im6qhc260yirs"; + url = "mirror://gnome/sources/${pname}/${major}/${pname}-${version}.tar.xz"; + sha256 = "41d8082e027f58bb5fa4181f93742606ab99c659794a18e2823eff22df0eecd9"; }; preConfigure = '' @@ -61,34 +63,30 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ intltool pkgconfig ]; - patches = [ ./nm-platform.patch ]; + preInstall = '' + installFlagsArray=( "sysconfdir=$out/etc" "localstatedir=$out/var" "runstatedir=$out/var/run" ) + ''; - preInstall = - '' - installFlagsArray=( "sysconfdir=$out/etc" "localstatedir=$out/var" ) - ''; + postInstall = '' + mkdir -p $out/lib/NetworkManager - postInstall = - '' - mkdir -p $out/lib/NetworkManager + # FIXME: Workaround until NixOS' dbus+systemd supports at_console policy + substituteInPlace $out/etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf --replace 'at_console="true"' 'group="networkmanager"' - # FIXME: Workaround until NixOS' dbus+systemd supports at_console policy - substituteInPlace $out/etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf --replace 'at_console="true"' 'group="networkmanager"' + # rename to network-manager to be in style + mv $out/etc/systemd/system/NetworkManager.service $out/etc/systemd/system/network-manager.service - # rename to network-manager to be in style - mv $out/etc/systemd/system/NetworkManager.service $out/etc/systemd/system/network-manager.service - - # systemd in NixOS doesn't use `systemctl enable`, so we need to establish - # aliases ourselves. - ln -s $out/etc/systemd/system/NetworkManager-dispatcher.service $out/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service - ln -s $out/etc/systemd/system/network-manager.service $out/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service - ''; + # systemd in NixOS doesn't use `systemctl enable`, so we need to establish + # aliases ourselves. + ln -s $out/etc/systemd/system/NetworkManager-dispatcher.service $out/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service + ln -s $out/etc/systemd/system/network-manager.service $out/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service + ''; meta = with stdenv.lib; { - homepage = http://projects.gnome.org/NetworkManager/; + homepage = http://projects.gnome.org/NetworkManager/; description = "Network configuration and management tool"; - license = licenses.gpl2Plus; - maintainers = with maintainers; [ phreedom urkud rickynils domenkozar ]; - platforms = platforms.linux; + license = licenses.gpl2Plus; + maintainers = with maintainers; [ phreedom urkud rickynils domenkozar obadz ]; + platforms = platforms.linux; }; } diff --git a/pkgs/tools/networking/network-manager/nm-platform.patch b/pkgs/tools/networking/network-manager/nm-platform.patch deleted file mode 100644 index 880d1a2e4921..000000000000 --- a/pkgs/tools/networking/network-manager/nm-platform.patch +++ /dev/null @@ -1,17 +0,0 @@ -diff --git a/src/platform/nm-platform.c b/src/platform/nm-platform.c -index 8803377..14e5726 100644 ---- a/src/platform/nm-platform.c -+++ b/src/platform/nm-platform.c -@@ -39,6 +39,12 @@ - #include "nm-enum-types.h" - #include "nm-core-internal.h" - -+#if HAVE_LIBNL_INET6_ADDR_GEN_MODE && HAVE_KERNEL_INET6_ADDR_GEN_MODE -+#include -+#else -+#define IN6_ADDR_GEN_MODE_NONE 1 -+#endif -+ - #define ADDRESS_LIFETIME_PADDING 5 - - G_STATIC_ASSERT (sizeof ( ((NMPlatformLink *) NULL)->addr.data ) == NM_UTILS_HWADDR_LEN_MAX); From 325f9e966de88415e026b69844da897fbc5bdbd3 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 01:46:23 +0100 Subject: [PATCH 05/11] network-manager-applet: 1.0.10 -> 1.2.2 --- .../network-manager-applet/default.nix | 29 +++++++------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/pkgs/tools/networking/network-manager-applet/default.nix b/pkgs/tools/networking/network-manager-applet/default.nix index 5e8931579cb3..a24f350d3f0b 100644 --- a/pkgs/tools/networking/network-manager-applet/default.nix +++ b/pkgs/tools/networking/network-manager-applet/default.nix @@ -3,20 +3,14 @@ , mobile_broadband_provider_info, glib_networking, gsettings_desktop_schemas , makeWrapper, udev, libgudev, hicolor_icon_theme }: -let - pn = "network-manager-applet"; - major = "1.0"; - # With version 1.0.12 of NM, we are no longer in sync - # version = "${networkmanager.version}.10"; - version = "${major}.10"; -in - stdenv.mkDerivation rec { - name = "network-manager-applet-${version}"; + name = "${pname}-${version}"; + pname = "network-manager-applet"; + version = networkmanager.version; src = fetchurl { - url = "mirror://gnome/sources/${pn}/${major}/${name}.tar.xz"; - sha256 = "1szh5jyijxm6z55irkp5s44pwah0nikss40mx7pvpk38m8zaqidh"; + url = "mirror://gnome/sources/${pname}/${networkmanager.major}/${name}.tar.xz"; + sha256 = "02b42e7c17c9cd6c840563750da92ce58da1ec621df7f0c2402016026e727756"; }; configureFlags = [ "--sysconfdir=/etc" ]; @@ -34,10 +28,9 @@ stdenv.mkDerivation rec { ''CFLAGS=-DMOBILE_BROADBAND_PROVIDER_INFO=\"${mobile_broadband_provider_info}/share/mobile-broadband-provider-info/serviceproviders.xml\"'' ]; - preInstall = - '' - installFlagsArray=( "sysconfdir=$out/etc" ) - ''; + preInstall = '' + installFlagsArray=( "sysconfdir=$out/etc" ) + ''; preFixup = '' wrapProgram "$out/bin/nm-applet" \ @@ -50,10 +43,10 @@ stdenv.mkDerivation rec { ''; meta = with stdenv.lib; { - homepage = http://projects.gnome.org/NetworkManager/; + homepage = http://projects.gnome.org/NetworkManager/; description = "NetworkManager control applet for GNOME"; - license = licenses.gpl2; + license = licenses.gpl2; maintainers = with maintainers; [ phreedom urkud rickynils ]; - platforms = platforms.linux; + platforms = platforms.linux; }; } From c434fd0659946944663425285547f85dad9890b7 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 02:03:11 +0100 Subject: [PATCH 06/11] network-manager/pptp: 1.0.12 -> 1.2.2 --- pkgs/tools/networking/network-manager/pptp.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/tools/networking/network-manager/pptp.nix b/pkgs/tools/networking/network-manager/pptp.nix index 12f28d840edd..7b4e0ae4c6ed 100644 --- a/pkgs/tools/networking/network-manager/pptp.nix +++ b/pkgs/tools/networking/network-manager/pptp.nix @@ -2,13 +2,13 @@ , libsecret, withGnome ? true, gnome3 }: stdenv.mkDerivation rec { - name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; - pname = "NetworkManager-pptp"; + name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; + pname = "NetworkManager-pptp"; version = networkmanager.version; src = fetchurl { - url = "mirror://gnome/sources/${pname}/1.0/${pname}-${version}.tar.xz"; - sha256 = "1gn1f8r32wznk4rsn2lg2slw1ccli00svz0fi4bx0qiylimlbyln"; + url = "mirror://gnome/sources/${pname}/${networkmanager.major}/${pname}-${version}.tar.xz"; + sha256 = "a72cb88ecc0a9edec836e8042c592d68b8b290c0d78082e6b25cf08b46c6be5d"; }; buildInputs = [ networkmanager pptp ppp libsecret ] From a8074165eff35115984ef95be06da599e43b32c4 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 01:53:23 +0100 Subject: [PATCH 07/11] network-manager/l2tp: 0.9.8.7 -> 1.2.2 --- .../tools/networking/network-manager/l2tp.nix | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/pkgs/tools/networking/network-manager/l2tp.nix b/pkgs/tools/networking/network-manager/l2tp.nix index fa349aa44c3d..a4795a47706f 100644 --- a/pkgs/tools/networking/network-manager/l2tp.nix +++ b/pkgs/tools/networking/network-manager/l2tp.nix @@ -1,20 +1,20 @@ { stdenv, fetchFromGitHub, automake, autoconf, libtool, intltool, pkgconfig -, networkmanager, ppp, xl2tpd, strongswan +, networkmanager, networkmanagerapplet, ppp, xl2tpd, strongswan, libsecret , withGnome ? true, gnome3 }: stdenv.mkDerivation rec { - name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; - pname = "NetworkManager-l2tp"; - version = "0.9.8.7"; + name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; + pname = "NetworkManager-l2tp"; + version = networkmanager.version; src = fetchFromGitHub { - owner = "seriyps"; - repo = "NetworkManager-l2tp"; + owner = "nm-l2tp"; + repo = "network-manager-l2tp"; rev = version; - sha256 = "07gl562p3f6l2wn64f3vvz1ygp3hsfhiwh4sn04c3fahfdys69zx"; + sha256 = "1zqdhm7pzhaq6q8pddj9ki25qs9m6qwqgzc5x07a0qffla2rq5j1"; }; - buildInputs = [ networkmanager ppp ] + buildInputs = [ networkmanager ppp networkmanagerapplet libsecret ] ++ stdenv.lib.optionals withGnome [ gnome3.gtk gnome3.libgnome_keyring ]; nativeBuildInputs = [ automake autoconf libtool intltool pkgconfig ]; @@ -25,9 +25,6 @@ stdenv.mkDerivation rec { substituteInPlace ./src/nm-l2tp-service.c \ --replace /sbin/ipsec ${strongswan}/bin/ipsec \ --replace /sbin/xl2tpd ${xl2tpd}/bin/xl2tpd - - # Workaround https://github.com/xelerance/xl2tpd/issues/108 - substituteInPlace ./src/nm-l2tp-service.c --replace 'write_config_option (pppopt_fd, "lock\n");' "" ''; preConfigure = "./autogen.sh"; From 9f3e2af9fe617e6c3670ebdbc5d63e1edc35e353 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 02:07:07 +0100 Subject: [PATCH 08/11] network-manager/openvpn: 1.0.12 -> 1.2.2 --- pkgs/tools/networking/network-manager/openvpn.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/tools/networking/network-manager/openvpn.nix b/pkgs/tools/networking/network-manager/openvpn.nix index 4b98600611e4..e6cb346c9288 100644 --- a/pkgs/tools/networking/network-manager/openvpn.nix +++ b/pkgs/tools/networking/network-manager/openvpn.nix @@ -2,13 +2,13 @@ , withGnome ? true, gnome3, procps, kmod }: stdenv.mkDerivation rec { - name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; - pname = "NetworkManager-openvpn"; + name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; + pname = "NetworkManager-openvpn"; version = networkmanager.version; src = fetchurl { - url = "mirror://gnome/sources/${pname}/1.0/${pname}-${version}.tar.xz"; - sha256 = "132xwkgyfnpma7m6b06jhrd1g9xk5dlpx8alnsf03ls3z92bd0n9"; + url = "mirror://gnome/sources/${pname}/${networkmanager.major}/${pname}-${version}.tar.xz"; + sha256 = "47a6d219a781eff8491c7876b7fb95b12dcfb8f8a05f916f95afc65c7babddef"; }; buildInputs = [ openvpn networkmanager libsecret ] From f337c2cf9cb5abf980f5a51e83afc0c5fbcdba23 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 02:09:21 +0100 Subject: [PATCH 09/11] network-manager/openconnect: 1.0.2 -> 1.2.2 --- .../tools/networking/network-manager/openconnect.nix | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/pkgs/tools/networking/network-manager/openconnect.nix b/pkgs/tools/networking/network-manager/openconnect.nix index 6a93100fa105..64b5fb20e892 100644 --- a/pkgs/tools/networking/network-manager/openconnect.nix +++ b/pkgs/tools/networking/network-manager/openconnect.nix @@ -2,15 +2,13 @@ , withGnome ? true, gnome3, procps, kmod }: stdenv.mkDerivation rec { - name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; - pname = "NetworkManager-openconnect"; - version = "1.0.2"; - -# FixMe: Change version back to "networkmanager.version" + name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; + pname = "NetworkManager-openconnect"; + version = networkmanager.version; src = fetchurl { - url = "mirror://gnome/sources/${pname}/1.0/${pname}-${version}.tar.xz"; - sha256 = "03k05s3aaxcwrip3g3r13bx80wbg7vh5sssc7mvg27c4cdc0a2hj"; + url = "mirror://gnome/sources/${pname}/${networkmanager.major}/${pname}-${version}.tar.xz"; + sha256 = "522979593e21b4e884112816708db9eb66148b3491580dacfad53472b94aafec"; }; buildInputs = [ openconnect networkmanager libsecret ] From 2cf9b5a6c0135675d1e1517218c9f4195ddba787 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 02:11:50 +0100 Subject: [PATCH 10/11] network-manager/vpnc: 1.0.12 -> 1.2.2 --- pkgs/tools/networking/network-manager/vpnc.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/tools/networking/network-manager/vpnc.nix b/pkgs/tools/networking/network-manager/vpnc.nix index 64de5408c7e0..0275a14bdf4a 100644 --- a/pkgs/tools/networking/network-manager/vpnc.nix +++ b/pkgs/tools/networking/network-manager/vpnc.nix @@ -2,13 +2,13 @@ , withGnome ? true, gnome3, procps, kmod }: stdenv.mkDerivation rec { - name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; - pname = "NetworkManager-vpnc"; + name = "${pname}${if withGnome then "-gnome" else ""}-${version}"; + pname = "NetworkManager-vpnc"; version = networkmanager.version; src = fetchurl { - url = "mirror://gnome/sources/${pname}/1.0/${pname}-${version}.tar.xz"; - sha256 = "0hycplnc78688sgpzdh3ifra6chascrh751mckqkp1j553bri0jk"; + url = "mirror://gnome/sources/${pname}/${networkmanager.major}/${pname}-${version}.tar.xz"; + sha256 = "e900f6500026f8c3ee4feb92e1d0a0c0abbee9ba507dad915b47a8ab7df9e1f3"; }; buildInputs = [ vpnc networkmanager libsecret ] From a9e995d67949890b1b9065c5657161d6b1f99650 Mon Sep 17 00:00:00 2001 From: obadz Date: Wed, 22 Jun 2016 02:51:15 +0100 Subject: [PATCH 11/11] network-manager & plugins: no longer remove -Werror and friends Code using deprecated APIs has been removed See comment by @dkosovic on the matter: https://github.com/xelerance/xl2tpd/issues/108#issuecomment-227621314 --- pkgs/tools/networking/network-manager/l2tp.nix | 2 -- pkgs/tools/networking/network-manager/openconnect.nix | 9 --------- pkgs/tools/networking/network-manager/openvpn.nix | 9 --------- pkgs/tools/networking/network-manager/pptp.nix | 2 -- pkgs/tools/networking/network-manager/vpnc.nix | 9 --------- 5 files changed, 31 deletions(-) diff --git a/pkgs/tools/networking/network-manager/l2tp.nix b/pkgs/tools/networking/network-manager/l2tp.nix index a4795a47706f..3cb6034db85d 100644 --- a/pkgs/tools/networking/network-manager/l2tp.nix +++ b/pkgs/tools/networking/network-manager/l2tp.nix @@ -32,8 +32,6 @@ stdenv.mkDerivation rec { configureFlags = if withGnome then "--with-gnome" else "--without-gnome"; - postConfigure = "sed 's/-Werror//g' -i Makefile */Makefile"; - meta = with stdenv.lib; { description = "L2TP plugin for NetworkManager"; inherit (networkmanager.meta) platforms; diff --git a/pkgs/tools/networking/network-manager/openconnect.nix b/pkgs/tools/networking/network-manager/openconnect.nix index 64b5fb20e892..43eb681be295 100644 --- a/pkgs/tools/networking/network-manager/openconnect.nix +++ b/pkgs/tools/networking/network-manager/openconnect.nix @@ -29,15 +29,6 @@ stdenv.mkDerivation rec { --replace "/sbin/modprobe" "${kmod}/sbin/modprobe" ''; - postConfigure = '' - substituteInPlace "./auth-dialog/Makefile" \ - --replace "-Wstrict-prototypes" "" \ - --replace "-Werror" "" - substituteInPlace "properties/Makefile" \ - --replace "-Wstrict-prototypes" "" \ - --replace "-Werror" "" - ''; - meta = { description = "NetworkManager's OpenConnect plugin"; inherit (networkmanager.meta) maintainers platforms; diff --git a/pkgs/tools/networking/network-manager/openvpn.nix b/pkgs/tools/networking/network-manager/openvpn.nix index e6cb346c9288..34e3a3e2959a 100644 --- a/pkgs/tools/networking/network-manager/openvpn.nix +++ b/pkgs/tools/networking/network-manager/openvpn.nix @@ -33,15 +33,6 @@ stdenv.mkDerivation rec { --replace "/sbin/openvpn" "${openvpn}/sbin/openvpn" ''; - postConfigure = '' - substituteInPlace "./auth-dialog/Makefile" \ - --replace "-Wstrict-prototypes" "" \ - --replace "-Werror" "" - substituteInPlace "properties/Makefile" \ - --replace "-Wstrict-prototypes" "" \ - --replace "-Werror" "" - ''; - meta = { description = "NetworkManager's OpenVPN plugin"; inherit (networkmanager.meta) maintainers platforms; diff --git a/pkgs/tools/networking/network-manager/pptp.nix b/pkgs/tools/networking/network-manager/pptp.nix index 7b4e0ae4c6ed..a9bee0c74811 100644 --- a/pkgs/tools/networking/network-manager/pptp.nix +++ b/pkgs/tools/networking/network-manager/pptp.nix @@ -28,8 +28,6 @@ stdenv.mkDerivation rec { configureFlags = if withGnome then "--with-gnome --with-gtkver=3" else "--without-gnome"; - postConfigure = "sed 's/-Werror//g' -i Makefile */Makefile"; - meta = { description = "PPtP plugin for NetworkManager"; inherit (networkmanager.meta) maintainers platforms; diff --git a/pkgs/tools/networking/network-manager/vpnc.nix b/pkgs/tools/networking/network-manager/vpnc.nix index 0275a14bdf4a..97b2001d7592 100644 --- a/pkgs/tools/networking/network-manager/vpnc.nix +++ b/pkgs/tools/networking/network-manager/vpnc.nix @@ -30,15 +30,6 @@ stdenv.mkDerivation rec { --replace "/sbin/modprobe" "${kmod}/sbin/modprobe" ''; - postConfigure = '' - substituteInPlace "./auth-dialog/Makefile" \ - --replace "-Wstrict-prototypes" "" \ - --replace "-Werror" "" - substituteInPlace "properties/Makefile" \ - --replace "-Wstrict-prototypes" "" \ - --replace "-Werror" "" - ''; - meta = { description = "NetworkManager's VPNC plugin"; inherit (networkmanager.meta) maintainers platforms;