BoomMicrophone/nixpkgs-suyu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

release-lib.nix: make packagePlatforms respect badPlatforms

Browse source 
packagePlatforms previously ignored badPlatforms, probably because it is
a fairly [recent] addition. While check-meta.nix doesn't implement it
using subtractLists, it is basically equivalent to the following logic:

  platformSet - badPlatformSet (= effectivePlatformSet)

which we implement using subtractLists (which has somewhat confusing
currying-optimized argument order).

This flaw was discovered when testing #177901 which heavily uses
badPlatforms.

[recent]: b0482248fe
This commit is contained in:
sternenseemann 2022-06-18 14:48:42 +02:00
parent 9a3e8f3cd4
commit f4286483ee
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkgs/top-level/release-lib.nix
View file

@ -146,7 +146,8 @@ rec {
packagePlatforms = mapAttrs (name: value:
if isDerivation value then
value.meta.hydraPlatforms
or (value.meta.platforms or [ "x86_64-linux" ])
or (lib.subtractLists (value.meta.badPlatforms or [])
(value.meta.platforms or [ "x86_64-linux" ]))
else if value.recurseForDerivations or false || value.recurseForRelease or false then
packagePlatforms value
else