From f04ef2a25b292144ba7856c96b2a96fee99639dc Mon Sep 17 00:00:00 2001 From: Alexandre Iooss Date: Fri, 13 Aug 2021 15:47:24 +0200 Subject: [PATCH] nixos/libreddit: do not test an error The current test needs Reddit access, which we do not have in testing environment. This commit tests the settings page of libreddit which does not require network access. It also test if the service can run on port 80 with the CAP_NET_BIND_SERVICE capability. --- nixos/tests/libreddit.nix | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/nixos/tests/libreddit.nix b/nixos/tests/libreddit.nix index f7ef701d0865..01f6aeffb366 100644 --- a/nixos/tests/libreddit.nix +++ b/nixos/tests/libreddit.nix @@ -6,14 +6,16 @@ with lib; name = "libreddit"; meta.maintainers = with maintainers; [ fab ]; - nodes.machine = - { pkgs, ... }: - { services.libreddit.enable = true; }; + nodes.machine = { + services.libreddit.enable = true; + # Test CAP_NET_BIND_SERVICE + services.libreddit.port = 80; + }; testScript = '' machine.wait_for_unit("libreddit.service") - machine.wait_for_open_port("8080") - # The service wants to get data from https://www.reddit.com - machine.succeed("curl http://localhost:8080/") + machine.wait_for_open_port("80") + # Query a page that does not require Internet access + machine.succeed("curl --fail http://localhost:80/settings") ''; })