From 0addac3b0a1cd1faf42ecd5f793fd8481dbada07 Mon Sep 17 00:00:00 2001 From: volth Date: Fri, 1 Jun 2018 20:56:19 +0000 Subject: [PATCH 1/2] lib: bitAnd, bitOr, bitXor --- lib/default.nix | 8 ++++---- lib/trivial.nix | 43 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 4 deletions(-) diff --git a/lib/default.nix b/lib/default.nix index 4ca2e2ea6e37..d608d7094474 100644 --- a/lib/default.nix +++ b/lib/default.nix @@ -56,10 +56,10 @@ let hasAttr head isAttrs isBool isInt isList isString length lessThan listToAttrs pathExists readFile replaceStrings seq stringLength sub substring tail; - inherit (trivial) id const concat or and boolToString mergeAttrs - flip mapNullable inNixShell min max importJSON warn info - nixpkgsVersion version mod compare splitByAndCompare - functionArgs setFunctionArgs isFunction; + inherit (trivial) id const concat or and bitAnd bitOr bitXor + boolToString mergeAttrs flip mapNullable inNixShell min max + importJSON warn info nixpkgsVersion version mod compare + splitByAndCompare functionArgs setFunctionArgs isFunction; inherit (fixedPoints) fix fix' extends composeExtensions makeExtensible makeExtensibleWithCustomName; diff --git a/lib/trivial.nix b/lib/trivial.nix index 251cb796db0e..86e3c939dd69 100644 --- a/lib/trivial.nix +++ b/lib/trivial.nix @@ -1,4 +1,38 @@ { lib }: +let + zipIntBits = f: x: y: + let + # (intToBits 6) -> [ 0 1 1 ] + intToBits = x: + if x==0 then + [] + else + let + headbit = if (x / 2) * 2 != x then 1 else 0; # x & 1 + tailbits = if x < 0 then 9223372036854775807 + ((x+1) / 2) else x / 2; # x >>> 1 + in + [headbit] ++ (intToBits tailbits); + + # (bitsToInt [ 0 1 1 ]) -> 6 + bitsToInt = l: + if l==[] then + 0 + else + (builtins.head l) + (2 * (bitsToInt (builtins.tail l))); + + zipListsWith' = fst: snd: + if fst==[] && snd==[] then + [] + else if fst==[] then + [(f 0 (builtins.head snd))] ++ (zipListsWith' [] (builtins.tail snd)) + else if snd==[] then + [(f (builtins.head fst) 0 )] ++ (zipListsWith' (builtins.tail fst) [] ) + else + [(f (builtins.head fst) (builtins.head snd))] ++ (zipListsWith' (builtins.tail fst) (builtins.tail snd)); + in + assert (builtins.isInt x) && (builtins.isInt y); + bitsToInt (zipListsWith' (intToBits x) (intToBits y)); +in rec { /* The identity function @@ -31,6 +65,15 @@ rec { /* boolean “and” */ and = x: y: x && y; + /* bitwise “and” */ + bitAnd = builtins.bitAnd or zipIntBits (a: b: if a==1 && b==1 then 1 else 0); + + /* bitwise “or” */ + bitOr = builtins.bitOr or zipIntBits (a: b: if a==1 || b==1 then 1 else 0); + + /* bitwise “xor” */ + bitXor = builtins.bitXor or zipIntBits (a: b: if a!=b then 1 else 0); + /* Convert a boolean to a string. Note that toString on a bool returns "1" and "". */ From 078b9b4c2b3348c3972c89acc66cdea48c5ec824 Mon Sep 17 00:00:00 2001 From: volth Date: Sat, 2 Jun 2018 21:13:43 +0000 Subject: [PATCH 2/2] lib: test for bitAnd, bitOr, bitXor --- lib/tests/misc.nix | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/tests/misc.nix b/lib/tests/misc.nix index c683df7d7ca3..eab20d0f14dc 100644 --- a/lib/tests/misc.nix +++ b/lib/tests/misc.nix @@ -45,6 +45,21 @@ runTests { expected = true; }; + testBitAnd = { + expr = (bitAnd 3 10); + expected = 2; + }; + + testBitOr = { + expr = (bitOr 3 10); + expected = 11; + }; + + testBitXor = { + expr = (bitXor 3 10); + expected = 9; + }; + # STRINGS testConcatMapStrings = {