tests.nixpkgs-check-by-name: More spaces in errors

This commit is contained in:
Silvan Mosberger 2024-02-23 02:16:49 +01:00
parent 1c4308c352
commit ce271786de
9 changed files with 19 additions and 5 deletions

View file

@ -204,7 +204,8 @@ impl fmt::Display for NixpkgsProblem {
Notably the second argument must not be empty, which is not the case. Notably the second argument must not be empty, which is not the case.
It is defined in {}:{} as It is defined in {}:{} as
{}", {}
",
structure::relative_dir_for_package(package_name).display(), structure::relative_dir_for_package(package_name).display(),
structure::relative_file_for_package(package_name).display(), structure::relative_file_for_package(package_name).display(),
file.display(), file.display(),
@ -222,7 +223,8 @@ impl fmt::Display for NixpkgsProblem {
This is however not the case: A different `callPackage` is used. This is however not the case: A different `callPackage` is used.
It is defined in {}:{} as It is defined in {}:{} as
{}", {}
",
structure::relative_dir_for_package(package_name).display(), structure::relative_dir_for_package(package_name).display(),
structure::relative_file_for_package(package_name).display(), structure::relative_file_for_package(package_name).display(),
file.display(), file.display(),
@ -240,7 +242,8 @@ impl fmt::Display for NixpkgsProblem {
This is however not the case: The first callPackage argument is not right: This is however not the case: The first callPackage argument is not right:
It is defined in {}:{} as It is defined in {}:{} as
{}", {}
",
structure::relative_dir_for_package(package_name).display(), structure::relative_dir_for_package(package_name).display(),
structure::relative_file_for_package(package_name).display(), structure::relative_file_for_package(package_name).display(),
file.display(), file.display(),
@ -258,7 +261,8 @@ impl fmt::Display for NixpkgsProblem {
This is however not the case: The first `callPackage` argument is the wrong path. This is however not the case: The first `callPackage` argument is the wrong path.
It is defined in {}:{}:{} as It is defined in {}:{}:{} as
{package_name} = callPackage {} {{ /* ... */ }};", {package_name} = callPackage {} {{ /* ... */ }};
",
structure::relative_dir_for_package(package_name).display(), structure::relative_dir_for_package(package_name).display(),
create_path_expr(file, expected_path), create_path_expr(file, expected_path),
file.display(), line, column, file.display(), line, column,
@ -275,7 +279,8 @@ impl fmt::Display for NixpkgsProblem {
This is however not the case. This is however not the case.
It is defined in {}:{} as It is defined in {}:{} as
{}", {}
",
structure::relative_dir_for_package(package_name).display(), structure::relative_dir_for_package(package_name).display(),
structure::relative_file_for_package(package_name).display(), structure::relative_file_for_package(package_name).display(),
file.display(), file.display(),

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:5 as It is defined in all-packages.nix:5 as
foo = self.alt.callPackage ({ }: self.someDrv) { }; foo = self.alt.callPackage ({ }: self.someDrv) { };
This PR introduces the above problems, merging would break the base branch This PR introduces the above problems, merging would break the base branch

View file

@ -6,6 +6,7 @@
It is defined in all-packages.nix:9 as It is defined in all-packages.nix:9 as
noEval = self.callPackage ./pkgs/by-name/no/noEval/package.nix { }; noEval = self.callPackage ./pkgs/by-name/no/noEval/package.nix { };
- Because pkgs/by-name/on/onlyMove exists, the attribute `pkgs.onlyMove` must be defined like - Because pkgs/by-name/on/onlyMove exists, the attribute `pkgs.onlyMove` must be defined like
onlyMove = callPackage ./pkgs/by-name/on/onlyMove/package.nix { /* ... */ }; onlyMove = callPackage ./pkgs/by-name/on/onlyMove/package.nix { /* ... */ };
@ -14,4 +15,5 @@
It is defined in all-packages.nix:7 as It is defined in all-packages.nix:7 as
onlyMove = self.callPackage ./pkgs/by-name/on/onlyMove/package.nix { }; onlyMove = self.callPackage ./pkgs/by-name/on/onlyMove/package.nix { };
This PR introduces the above problems compared to the base branch, merging is discouraged, but would not break the base branch This PR introduces the above problems compared to the base branch, merging is discouraged, but would not break the base branch

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:4 as It is defined in all-packages.nix:4 as
foo = self.bar; foo = self.bar;
This PR introduces the above problems, merging would break the base branch This PR introduces the above problems, merging would break the base branch

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:2:3 as It is defined in all-packages.nix:2:3 as
nonDerivation = callPackage ./someDrv.nix { /* ... */ }; nonDerivation = callPackage ./someDrv.nix { /* ... */ };
This PR introduces the above problems, merging would break the base branch This PR introduces the above problems, merging would break the base branch

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:2 as It is defined in all-packages.nix:2 as
nonDerivation = self.callPackage ./pkgs/by-name/no/nonDerivation/package.nix { }; nonDerivation = self.callPackage ./pkgs/by-name/no/nonDerivation/package.nix { };
This PR introduces the above problems compared to the base branch, merging is discouraged, but would not break the base branch This PR introduces the above problems compared to the base branch, merging is discouraged, but would not break the base branch

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:2 as It is defined in all-packages.nix:2 as
nonDerivation = self.someDrv; nonDerivation = self.someDrv;
This PR introduces the above problems, merging would break the base branch This PR introduces the above problems, merging would break the base branch

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:2 as It is defined in all-packages.nix:2 as
nonDerivation = self.callPackage ({ someDrv }: someDrv) { }; nonDerivation = self.callPackage ({ someDrv }: someDrv) { };
This PR introduces the above problems, merging would break the base branch This PR introduces the above problems, merging would break the base branch

View file

@ -6,4 +6,5 @@
It is defined in all-packages.nix:3 as It is defined in all-packages.nix:3 as
foo = self.callPackage ({ someDrv, someFlag }: someDrv) { someFlag = true; }; foo = self.callPackage ({ someDrv, someFlag }: someDrv) { someFlag = true; };
This PR introduces the above problems, merging would break the base branch This PR introduces the above problems, merging would break the base branch