Merge pull request #247321 from paveloom/picard

picard: 2.8.5 -> 2.9
This commit is contained in:
Weijia Wang 2023-08-06 00:24:55 +02:00 committed by GitHub
commit 8d45a93a96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -10,7 +10,8 @@
let let
pythonPackages = python3Packages; pythonPackages = python3Packages;
pyqt5 = if enablePlayback then pyqt5 =
if enablePlayback then
pythonPackages.pyqt5_with_qtmultimedia pythonPackages.pyqt5_with_qtmultimedia
else else
pythonPackages.pyqt5 pythonPackages.pyqt5
@ -18,13 +19,13 @@ let
in in
pythonPackages.buildPythonApplication rec { pythonPackages.buildPythonApplication rec {
pname = "picard"; pname = "picard";
version = "2.8.5"; version = "2.9";
src = fetchFromGitHub { src = fetchFromGitHub {
owner = "metabrainz"; owner = "metabrainz";
repo = pname; repo = "picard";
rev = "refs/tags/release-${version}"; rev = "refs/tags/release-${version}";
sha256 = "sha256-ukqlAXGaqX89U77cM9Ux0RYquT31Ho8ri1Ue7S3+MwQ="; hash = "sha256-ultpLz4u2wBxoL4YbNeZ4Z4NEXBvqpxJ8mzFeGQTt4A=";
}; };
nativeBuildInputs = [ nativeBuildInputs = [
@ -37,6 +38,7 @@ pythonPackages.buildPythonApplication rec {
gst_all_1.gst-vaapi gst_all_1.gst-vaapi
gst_all_1.gstreamer gst_all_1.gstreamer
]; ];
buildInputs = [ buildInputs = [
qt5.qtbase qt5.qtbase
qt5.qtwayland qt5.qtwayland
@ -56,20 +58,23 @@ pythonPackages.buildPythonApplication rec {
pyyaml pyyaml
]; ];
preCheck = ''
export HOME=$(mktemp -d)
'';
# In order to spare double wrapping, we use: # In order to spare double wrapping, we use:
preFixup = '' preFixup = ''
makeWrapperArgs+=("''${qtWrapperArgs[@]}") makeWrapperArgs+=("''${qtWrapperArgs[@]}")
'' ''
+ lib.optionalString (pyqt5.multimediaEnabled) '' + lib.optionalString (pyqt5.multimediaEnabled) ''
makeWrapperArgs+=(--prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0") makeWrapperArgs+=(--prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0")
'' '';
;
meta = with lib; { meta = with lib; {
homepage = "https://picard.musicbrainz.org/"; homepage = "https://picard.musicbrainz.org/";
changelog = "https://picard.musicbrainz.org/changelog/"; changelog = "https://picard.musicbrainz.org/changelog/";
description = "The official MusicBrainz tagger"; description = "The official MusicBrainz tagger";
maintainers = with maintainers; [ ehmry ]; maintainers = with maintainers; [ ehmry paveloom ];
license = licenses.gpl2Plus; license = licenses.gpl2Plus;
platforms = platforms.all; platforms = platforms.all;
}; };