BoomMicrophone/nixpkgs-suyu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mps: fix gcc-13 build failure by dropping -Werror

Browse source 
Without the change build fails on `master` as
https://hydra.nixos.org/build/249125931:

    ss.c: In function 'StackHot':
    ss.c:38:13: error: storing the address of local variable 'stackOut' in '*stackOut' [-Werror=dangling-pointer=8]
       38 |   *stackOut = &stackOut;
          |   ~~~~~~~~~~^~~~~~~~~~~

Blanket `-Werror` tends to break with minor toolchain and dependency
changes. It's a reasonable option to test upstream and use downstream
only if upstream is quick at addressing builds failures. `gcc-13` is
almost a year old.
This commit is contained in:
Sergei Trofimovich 2024-02-19 22:05:13 +00:00
parent 6021282979
commit 70f9aaa0f4
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
pkgs/development/libraries/mps/default.nix
View file

@ -16,17 +16,17 @@ stdenv.mkDerivation rec {
hash = "sha256-3ql3jWLccgnQHKf23B1en+nJ9rxqmHcWd7aBr93YER0=";
};
postPatch = ''
# Disable -Werror to avoid biuld failure on fresh toolchains like
# gcc-13.
substituteInPlace code/gc.gmk --replace-fail '-Werror ' ' '
substituteInPlace code/gp.gmk --replace-fail '-Werror ' ' '
substituteInPlace code/ll.gmk --replace-fail '-Werror ' ' '
'';
nativeBuildInputs = [ autoreconfHook ];
buildInputs = [ sqlite ];
# needed for 1.116.0 to build with gcc7
env.NIX_CFLAGS_COMPILE = toString [
"-Wno-implicit-fallthrough"
"-Wno-error=clobbered"
"-Wno-error=cast-function-type"
];
meta = {
description = "A flexible memory management and garbage collection library";
homepage = "https://www.ravenbrook.com/project/mps";