tdb: clean up expression

* format with nixpkgs-fmt
* quote homepage as per RFC 0045
* split name → pname & version
* do not use aliases
* switch to wafHook

pkgs/development/libraries/tdb/default.nix

@@ -1,23 +1,34 @@
-{ stdenv, fetchurl, pkgconfig
-, wafHook, python3, readline
-, libxslt, docbook_xsl, docbook_xml_dtd_45
+{ stdenv
+, fetchurl
+, pkg-config
+, wafHook
+, python
+, readline
+, libxslt
+, docbook-xsl-nons
+, docbook_xml_dtd_45
 }:
 
 stdenv.mkDerivation rec {
-  name = "tdb-1.4.3";
+  pname = "tdb";
+  version = "1.4.3";
 
   src = fetchurl {
-    url = "mirror://samba/tdb/${name}.tar.gz";
+    url = "mirror://samba/tdb/${pname}-${version}.tar.gz";
     sha256 = "06waz0k50c7v3chd08mzp2rv7w4k4q9isbxx3vhlfpx1vy9q61f8";
   };
 
   nativeBuildInputs = [
-    pkgconfig wafHook
-    libxslt docbook_xsl docbook_xml_dtd_45
+    pkg-config
+    wafHook
+    libxslt
+    docbook-xsl-nons
+    docbook_xml_dtd_45
   ];
 
   buildInputs = [
-    python3 readline
+    python
+    readline # required to build python
   ];
 
   wafPath = "buildtools/bin/waf";
@@ -35,7 +46,7 @@ stdenv.mkDerivation rec {
       and uses locking internally to keep writers from trampling on each
       other. TDB is also extremely small.
     '';
-    homepage = https://tdb.samba.org/;
+    homepage = "https://tdb.samba.org/";
     license = licenses.lgpl3Plus;
     platforms = platforms.all;
   };