From 261f090079616e6823a076f6ce30ee0c78c5dab4 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Sun, 3 Jul 2022 21:29:08 -0700 Subject: [PATCH] git-lfs: remove leaveDotGit=true Since commit 0b0119f1ea0c7d367569a68e1c90e2d04968867e on 2022-Jun-04, `git-lfs` no longer builds with `--option substituters ""`: ``` error: hash mismatch in fixed-output derivation '/nix/store/2g1jwczzld8l190s2apc0ihffmil385f-source.drv': specified: sha256-3gVUPfZs5GViEA3D7Zm5NdxhuEz9DhwPLoQqHFdGCrI= got: sha256-D7ZA04HZOG8DcejW+S91c5HjVIW+SLMzXZHylpARwrQ= note: keeping build directory '/tmp/nix-build-source.drv-3' error: 1 dependencies of derivation '/nix/store/jzl8ypirdrii6aik2pss84df7sds7vqr-git-lfs-3.2.0.drv' failed to build `` It appears that the hash `sha256-3gVUPfZs5GViEA3D7Zm5NdxhuEz9DhwPLoQqHFdGCrI=` was calculated based on `fetchDotGit=false`, and was in cachix, so nobody noticed that the hash doesn't match the fetcher expression. This is yet another case of an ongoing problem with nixpkgs: we have no way of noticing when a fetcher expression has the wrong hash if that incorrect hash happens to be the hash of something that is in cachix. Apparently nobody (else) is checking that nixpkgs works with `--option substituters ""`. --- pkgs/applications/version-management/git-lfs/default.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/pkgs/applications/version-management/git-lfs/default.nix b/pkgs/applications/version-management/git-lfs/default.nix index 6740cb713f86..45a5234accb1 100644 --- a/pkgs/applications/version-management/git-lfs/default.nix +++ b/pkgs/applications/version-management/git-lfs/default.nix @@ -9,7 +9,6 @@ buildGoModule rec { repo = "git-lfs"; rev = "v${version}"; sha256 = "sha256-3gVUPfZs5GViEA3D7Zm5NdxhuEz9DhwPLoQqHFdGCrI="; - leaveDotGit = true; }; vendorSha256 = null;