BoomMicrophone/nixpkgs-suyu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libreoffice-unwrapped: fix default --with-help build value

Browse source 
Previously, only if `withHelp` was `false`, we added the `./configure`
flag `--without-help`, but apparently `--without-help` does nothing, as
not building help is the default behavior. Using `lib.withFeature` gives
the most expected behavior no matter what are the defaults. Quoting from
`./configure --help` for reference:

> --with-help             Enable the build of help. There is a special
>                         parameter "common" that can be used to bundle only
>                         the common part, .e.g help-specific icons. This is
>                         useful when you build the helpcontent separately.
>
>                         Usage:     --with-help    build the old local help
>                                --without-help     no local help (default)
>                                --with-help=html   build the new HTML local help
>                                --with-help=online build the new HTML online help

This commit fixes #276400.
This commit is contained in:
Doron Behar 2023-12-24 11:52:51 +02:00
parent 4fa6181085
commit 202588714c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkgs/applications/office/libreoffice/default.nix
View file

@ -415,7 +415,7 @@ in stdenv.mkDerivation (finalAttrs: {
dontWrapQtApps = true;
configureFlags = [
(lib.optionalString (!withHelp) "--without-help")
(lib.withFeature withHelp "help")
"--with-boost=${getDev boost}"
"--with-boost-libdir=${getLib boost}/lib"
"--with-beanshell-jar=${bsh}"