From 125bb927059fed98c8913c8476b83585085b8110 Mon Sep 17 00:00:00 2001
From: OTABI Tomoya <tomoya.otabi@gmail.com>
Date: Thu, 29 Jun 2023 00:08:47 +0900
Subject: [PATCH] streamlit: 1.21.0 -> 1.24.0 (#240248)

Diff: https://github.com/streamlit/streamlit/compare/1.21.0...1.24.0

Changelog: https://github.com/streamlit/streamlit/releases/tag/1.24.0
---
 .../machine-learning/streamlit/default.nix       | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/pkgs/applications/science/machine-learning/streamlit/default.nix b/pkgs/applications/science/machine-learning/streamlit/default.nix
index 3db5356b4964..36b03152f787 100755
--- a/pkgs/applications/science/machine-learning/streamlit/default.nix
+++ b/pkgs/applications/science/machine-learning/streamlit/default.nix
@@ -17,6 +17,7 @@
 , rich
 , semver
 , setuptools
+, tenacity
 , toml
 , tornado
 , tzlocal
@@ -26,12 +27,12 @@
 
 buildPythonApplication rec {
   pname = "streamlit";
-  version = "1.21.0";
-  format = "wheel"; # source currently requires pipenv
+  version = "1.24.0";
+  format = "setuptools";
 
   src = fetchPypi {
     inherit pname version format;
-    hash = "sha256-BYYlmJUqkSbhZlLKpbyI7u6nsnc68lLi2szxyEzqrvQ=";
+    hash = "sha256-NSX6zpTHh5JzPFbWOja0iEUVDjume7UKGa20xZdagiU=";
   };
 
   propagatedBuildInputs = [
@@ -51,6 +52,7 @@ buildPythonApplication rec {
     rich
     semver
     setuptools
+    tenacity
     toml
     tornado
     tzlocal
@@ -58,12 +60,20 @@ buildPythonApplication rec {
     watchdog
   ];
 
+  # pypi package does not include the tests, but cannot be built with fetchFromGitHub
+  doCheck = false;
+
+  pythonImportsCheck = [
+    "streamlit"
+  ];
+
   postInstall = ''
     rm $out/bin/streamlit.cmd # remove windows helper
   '';
 
   meta = with lib; {
     homepage = "https://streamlit.io/";
+    changelog = "https://github.com/streamlit/streamlit/releases/tag/${version}";
     description = "The fastest way to build custom ML tools";
     maintainers = with maintainers; [ yrashk ];
     license = licenses.asl20;