nixpkgs-suyu/pkgs/os-specific/linux/lvm2/common.nix

123 lines
3.7 KiB
Nix
Raw Normal View History

2021-10-17 15:46:26 +02:00
{ version, sha256Hash }:
{ lib, stdenv
, fetchpatch
, fetchurl
, pkg-config
2020-11-24 16:29:28 +01:00
, util-linux
, libuuid
lvm2: Remove dependency on thin-provisioning-tools thin-provisioning-tools has a _huge_ closure size (hundreds of megabytes) and the only reference in the output of the lvm2 package is a _comment_ in the etc/lvm.conf The lvm2 package thus does not seem to depend on thin-provisoning-tools in any way. Reverts 9326a89910434f96b3af4dd7758614e0143735e2 thin provisoning is broken with or without this change: https://github.com/NixOS/nixpkgs/issues/15516 A proper fix is here: https://github.com/NixOS/nixpkgs/pull/46541 References: $ nix why-depends nixpkgs#lvm2 nixpkgs#thin-provisioning-tools /nix/store/n7zwwxi0ihjks7qk9bq5lbkniligfcqc-lvm2-2.03.11 └───etc/lvm.conf: …_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-prov> → /nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0 $ ag thin-provisioning-tools --search-binary etc/lvm.conf 1093: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1095: # thin_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_check" 1100: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1102: # thin_dump_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_dump" 1108: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1110: # thin_repair_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_repair" 1155: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1157: # cache_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_check" 1162: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1164: # cache_dump_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_dump" 1170: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1172: # cache_repair_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_repair"
2021-05-01 13:38:07 +02:00
, libaio
, enableCmdlib ? false
, enableDmeventd ? false
, udev ? null
2020-07-14 12:56:26 +02:00
, nixosTests
}:
# configure: error: --enable-dmeventd requires --enable-cmdlib to be used as well
assert enableDmeventd -> enableCmdlib;
2020-05-25 03:37:44 +02:00
stdenv.mkDerivation rec {
2021-10-17 15:46:26 +02:00
pname = "lvm2" + lib.optionalString enableDmeventd "-with-dmeventd";
inherit version;
src = fetchurl {
url = "https://mirrors.kernel.org/sourceware/lvm2/LVM2.${version}.tgz";
2021-10-17 15:46:26 +02:00
sha256 = sha256Hash;
};
nativeBuildInputs = [ pkg-config ];
lvm2: Remove dependency on thin-provisioning-tools thin-provisioning-tools has a _huge_ closure size (hundreds of megabytes) and the only reference in the output of the lvm2 package is a _comment_ in the etc/lvm.conf The lvm2 package thus does not seem to depend on thin-provisoning-tools in any way. Reverts 9326a89910434f96b3af4dd7758614e0143735e2 thin provisoning is broken with or without this change: https://github.com/NixOS/nixpkgs/issues/15516 A proper fix is here: https://github.com/NixOS/nixpkgs/pull/46541 References: $ nix why-depends nixpkgs#lvm2 nixpkgs#thin-provisioning-tools /nix/store/n7zwwxi0ihjks7qk9bq5lbkniligfcqc-lvm2-2.03.11 └───etc/lvm.conf: …_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-prov> → /nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0 $ ag thin-provisioning-tools --search-binary etc/lvm.conf 1093: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1095: # thin_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_check" 1100: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1102: # thin_dump_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_dump" 1108: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1110: # thin_repair_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_repair" 1155: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1157: # cache_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_check" 1162: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1164: # cache_dump_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_dump" 1170: # (See package device-mapper-persistent-data or thin-provisioning-tools) 1172: # cache_repair_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_repair"
2021-05-01 13:38:07 +02:00
buildInputs = [ udev libuuid libaio ];
2015-08-19 02:01:13 +02:00
configureFlags = [
"--disable-readline"
"--enable-pkgconfig"
"--with-default-locking-dir=/run/lock/lvm"
"--with-default-run-dir=/run/lvm"
"--with-systemdsystemunitdir=${placeholder "out"}/lib/systemd/system"
2021-01-15 15:45:37 +01:00
] ++ lib.optionals (!enableCmdlib) [
"--bindir=${placeholder "bin"}/bin"
"--sbindir=${placeholder "bin"}/bin"
"--libdir=${placeholder "lib"}/lib"
2021-01-15 15:45:37 +01:00
] ++ lib.optional enableCmdlib "--enable-cmdlib"
++ lib.optionals enableDmeventd [
"--enable-dmeventd"
"--with-dmeventd-pidfile=/run/dmeventd/pid"
"--with-default-dm-run-dir=/run/dmeventd"
2021-01-15 15:45:37 +01:00
] ++ lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [
2017-10-29 22:02:14 +01:00
"ac_cv_func_malloc_0_nonnull=yes"
"ac_cv_func_realloc_0_nonnull=yes"
] ++
2021-01-15 15:45:37 +01:00
lib.optionals (udev != null) [
"--enable-udev_rules"
"--enable-udev_sync"
2017-10-29 22:02:14 +01:00
];
2015-08-19 02:01:13 +02:00
preConfigure = ''
sed -i /DEFAULT_SYS_DIR/d Makefile.in
sed -i /DEFAULT_PROFILE_DIR/d conf/Makefile.in
substituteInPlace scripts/lvm2_activation_generator_systemd_red_hat.c \
--replace /usr/bin/udevadm /run/current-system/systemd/bin/udevadm
# https://github.com/lvmteam/lvm2/issues/36
substituteInPlace udev/69-dm-lvm-metad.rules.in \
--replace "(BINDIR)/systemd-run" /run/current-system/systemd/bin/systemd-run
substituteInPlace make.tmpl.in --replace "@systemdsystemunitdir@" "$out/lib/systemd/system"
2021-10-17 15:46:26 +02:00
'' + lib.optionalString (lib.versionAtLeast version "2.03") ''
substituteInPlace libdm/make.tmpl.in --replace "@systemdsystemunitdir@" "$out/lib/systemd/system"
'';
2014-04-15 18:02:07 +02:00
postConfigure = ''
sed -i 's|^#define LVM_CONFIGURE_LINE.*$|#define LVM_CONFIGURE_LINE "<removed>"|g' ./include/configure.h
'';
patches = [
# Musl fixes from Alpine.
./fix-stdio-usage.patch
2018-01-14 07:55:12 +01:00
(fetchpatch {
name = "mallinfo.patch";
url = "https://git.alpinelinux.org/aports/plain/main/lvm2/mallinfo.patch?h=3.7-stable&id=31bd4a8c2dc00ae79a821f6fe0ad2f23e1534f50";
2018-01-14 07:55:12 +01:00
sha256 = "0g6wlqi215i5s30bnbkn8w7axrs27y3bnygbpbnf64wwx7rxxlj0";
})
];
doCheck = false; # requires root
2021-01-15 15:45:37 +01:00
makeFlags = lib.optionals (udev != null) [
"SYSTEMD_GENERATOR_DIR=$(out)/lib/systemd/system-generators"
];
# To prevent make install from failing.
2019-11-15 11:36:01 +01:00
installFlags = [ "OWNER=" "GROUP=" "confdir=$(out)/etc" ];
2012-08-16 21:36:25 +02:00
# Install systemd stuff.
2021-01-15 15:45:37 +01:00
installTargets = [ "install" ] ++ lib.optionals (udev != null) [
"install_systemd_generators"
"install_systemd_units"
"install_tmpfiles_configuration"
];
2012-08-16 21:36:25 +02:00
# only split bin and lib out from out if cmdlib isn't enabled
outputs = [
"out"
"dev"
"man"
2021-01-15 15:45:37 +01:00
] ++ lib.optionals (enableCmdlib != true) [
"bin"
"lib"
];
2021-01-15 15:45:37 +01:00
postInstall = lib.optionalString (enableCmdlib != true) ''
2020-05-24 02:27:51 +02:00
moveToOutput lib/libdevmapper.so $lib
'';
2020-07-14 12:56:26 +02:00
passthru.tests.installer = nixosTests.installer.lvm;
meta = with lib; {
homepage = "http://sourceware.org/lvm2/";
description = "Tools to support Logical Volume Management (LVM) on Linux";
2018-08-17 22:30:55 +02:00
platforms = platforms.linux;
license = with licenses; [ gpl2 bsd2 lgpl21 ];
2020-05-22 01:59:29 +02:00
maintainers = with maintainers; [ raskin ajs124 ];
};
}