nixpkgs-suyu/.github/PULL_REQUEST_TEMPLATE.md

###### Motivation for this change


###### Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
   - [ ] NixOS
   - [ ] macOS
   - [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Assured whether relevant documentation is up to date
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

---
Update PR template with motivation for changes I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change. 2016-05-24 13:59:46 +02:00			`###### Motivation for this change`


Simplify contributing * Highlight the top mistakes directly in CONTRIBUTING.md * Remove unecessary cruft from the PR template 2016-04-09 18:53:24 +02:00			`###### Things done`
PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406 2016-02-28 10:26:21 +01:00
Pull request template: comment out instructions 2017-08-12 16:17:39 +02:00			`<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->`
Pull request template: clarify the purpose of the template 2017-07-22 18:04:19 +02:00
use sandbox instead of build-use-sandbox 2018-05-30 21:48:07 +02:00			- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes 2016-03-16 09:46:05 +01:00			`- Built on platform(s)`
			`- [ ] NixOS`
Update PULL_REQUEST_TEMPLATE.md Follow the rebranding of OS X into macOS 2016-11-04 16:49:40 +01:00			`- [ ] macOS`
pr template: make values of platform field less ambiguous 2017-10-09 12:47:59 +02:00			`- [ ] other Linux distributions`
github/pr-template: Add note about NixOS tests On several occasions I've seen people bumping packages which have NixOS tests but without actually running them. While this probably won't prevent such occasions entirely, at least it serves as an additional checklist item so contributors don't forget about these tests. Signed-off-by: aszlig <aszlig@redmoonstudios.org> 2017-06-23 05:33:06 +02:00			`- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))`
doc/reviewing-contributions: nix-review instead of nox-review It is faster, handles more edge cases and allows to test/review the built packages interactively. 2019-03-08 15:17:28 +01:00			- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
PULL_REQUEST_TEMPLATE.md: clarify a few things 2016-02-28 09:49:55 +01:00			- [ ] Tested execution of all binary files (usually in `./result/bin/`)
PULL_REQUEST_TEMPLATE.md: Ask for closure size impact 2018-06-21 18:51:45 +02:00			- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
PULL_REQUEST_TEMPLATE: Ask for docs 2017-07-12 16:04:39 +02:00			`- [ ] Assured whether relevant documentation is up to date`
PULL_REQUEST_TEMPLATE: init 2016-02-18 17:26:17 +01:00			`- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).`

			`---`