2015-04-07 15:11:59 +02:00
# How to contribute
2015-12-19 14:34:58 +01:00
Note: contributing implies licensing those contributions
2016-02-23 14:47:43 +01:00
under the terms of [COPYING ](../COPYING ), which is an MIT-like license.
2015-12-19 14:34:58 +01:00
2015-04-07 15:11:59 +02:00
## Opening issues
* Make sure you have a [GitHub account ](https://github.com/signup/free )
2015-06-21 17:32:54 +02:00
* [Submit an issue ](https://github.com/NixOS/nixpkgs/issues ) - assuming one does not already exist.
* Clearly describe the issue including steps to reproduce when it is a bug.
* Include information what version of nixpkgs and Nix are you using (nixos-version or git revision).
2015-04-07 15:11:59 +02:00
## Submitting changes
2017-11-13 10:02:56 +01:00
* Format the commit messages in the following way:
2016-04-09 18:53:24 +02:00
2017-02-06 21:26:32 +01:00
```
2017-07-15 16:32:01 +02:00
(pkg-name | nixos/< module > ): (from -> to | init at version | refactor | etc)
2017-11-13 10:02:56 +01:00
2017-02-06 21:26:32 +01:00
(Motivation for change. Additional information.)
```
2016-04-09 18:53:24 +02:00
2018-10-10 23:06:12 +02:00
For consistency, there should not be a period at the end of the commit message's summary line (the first line of the commit message).
2018-10-08 19:18:58 +02:00
2016-04-09 18:53:24 +02:00
Examples:
* nginx: init at 2.0.1
2017-09-01 19:55:34 +02:00
* firefox: 54.0.1 -> 55.0
2017-07-15 16:32:01 +02:00
* nixos/hydra: add bazBaz option
2017-11-13 10:02:56 +01:00
2017-02-06 21:26:32 +01:00
Dual baz behavior is needed to do foo.
2017-07-15 16:32:01 +02:00
* nixos/nginx: refactor config generation
2017-11-13 10:02:56 +01:00
2017-02-06 21:26:32 +01:00
The old config generation system used impure shell scripts and could break in specific circumstances (see #1234 ).
2016-04-09 18:53:24 +02:00
2016-04-09 21:50:48 +02:00
* `meta.description` should:
2017-09-22 15:12:49 +02:00
* Be capitalized.
* Not start with the package name.
* Not have a period at the end.
* `meta.license` must be set and fit the upstream license.
2017-10-09 11:37:02 +02:00
* If there is no upstream license, `meta.license` should default to `stdenv.lib.licenses.unfree` .
2017-09-22 15:12:49 +02:00
* `meta.maintainers` must be set.
2016-04-09 18:53:24 +02:00
2017-09-22 15:12:49 +02:00
See the nixpkgs manual for more details on [standard meta-attributes ](https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes ) and on how to [submit changes to nixpkgs ](https://nixos.org/nixpkgs/manual/#chap-submitting-changes ).
2016-04-09 18:53:24 +02:00
2017-02-06 21:26:32 +01:00
## Writing good commit messages
2018-08-23 15:19:02 +02:00
In addition to writing properly formatted commit messages, it's important to include relevant information so other developers can later understand *why* a change was made. While this information usually can be found by digging code, mailing list/Discourse archives, pull request discussions or upstream changes, it may require a lot of work.
2017-02-06 21:26:32 +01:00
For package version upgrades and such a one-line commit message is usually sufficient.
2016-09-26 08:36:03 +02:00
## Reviewing contributions
2019-10-28 18:49:17 +01:00
See the nixpkgs manual for more details on how to [Review contributions ](https://nixos.org/nixpkgs/manual/#chap-reviewing-contributions ).