BoomMicrophone/nixpkgs-suyu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
nixpkgs-suyu/pkgs/applications/audio/gbsplay/default.nix

29 lines
764 B
Nix
Raw Normal View History

treewide: with stdenv.lib; in meta -> with lib; Part of: https://github.com/NixOS/nixpkgs/issues/108938 meta = with stdenv.lib; is a widely used pattern. We want to slowly remove the `stdenv.lib` indirection and encourage people to use `lib` directly. Thus let’s start with the meta field. This used a rewriting script to mostly automatically replace all occurances of this pattern, and add the `lib` argument to the package header if it doesn’t exist yet. The script in its current form is available at https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix
2021-01-11 08:54:33 +01:00
{ lib, stdenv, fetchFromGitHub, libpulseaudio }:
gbsplay: init at version 2016-12-17
2017-01-25 21:59:27 +01:00
stdenv.mkDerivation {
name = "gbsplay-2016-12-17";
src = fetchFromGitHub {
owner = "mmitch";
repo = "gbsplay";
rev = "2c4486e17fd4f4cdea8c3fd79ae898c892616b70";
sha256 = "1214j67sr87zfhvym41cw2g823fmqh4hr451r7y1s9ql3jpjqhpz";
};
buildInputs = [ libpulseaudio ];
gbsplay: fix configure flags This caused none of these flags to have any effect. That's because the configure command looked like this: ./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \ --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n with one giant flag '--without-test --without-contrib...', containing internal spaces. This can be seen in `nix log nixpkgs.gbsplay`, in this line: configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n and then in the fact that features like "devdsp" and "midi" are listed as enabled in later output, and source files like plugout_midi.c are included in the build. I don't have a real opinion on whether it's better to have these flags or not, but it's clear the author's intention was to pass them. So, fix the attr name so they get passed.
2020-04-09 08:41:41 +02:00
configureFlags =
fixing gbsplay/default.nix
2017-01-26 00:41:54 +01:00
[ "--without-test" "--without-contrib" "--disable-devdsp"
"--enable-pulse" "--disable-alsa" "--disable-midi"
"--disable-nas" "--disable-dsound" "--disable-i18n" ];
gbsplay: init at version 2016-12-17
2017-01-25 21:59:27 +01:00
gbsplay: fix configure flags This caused none of these flags to have any effect. That's because the configure command looked like this: ./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \ --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n with one giant flag '--without-test --without-contrib...', containing internal spaces. This can be seen in `nix log nixpkgs.gbsplay`, in this line: configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n and then in the fact that features like "devdsp" and "midi" are listed as enabled in later output, and source files like plugout_midi.c are included in the build. I don't have a real opinion on whether it's better to have these flags or not, but it's clear the author's intention was to pass them. So, fix the attr name so they get passed.
2020-04-09 08:41:41 +02:00
makeFlags = [ "tests=" ];
gbsplay: init at version 2016-12-17
2017-01-25 21:59:27 +01:00
treewide: with stdenv.lib; in meta -> with lib; Part of: https://github.com/NixOS/nixpkgs/issues/108938 meta = with stdenv.lib; is a widely used pattern. We want to slowly remove the `stdenv.lib` indirection and encourage people to use `lib` directly. Thus let’s start with the meta field. This used a rewriting script to mostly automatically replace all occurances of this pattern, and add the `lib` argument to the package header if it doesn’t exist yet. The script in its current form is available at https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix
2021-01-11 08:54:33 +01:00
meta = with lib; {
gbsplay: init at version 2016-12-17
2017-01-25 21:59:27 +01:00
description = "gameboy sound player";
license = licenses.gpl1;
fixing gbsplay/default.nix
2017-01-26 00:41:54 +01:00
platforms = ["i686-linux" "x86_64-linux"];
gbsplay: init at version 2016-12-17
2017-01-25 21:59:27 +01:00
maintainers = with maintainers; [ dasuxullebt ];
};
}
Reference in a new issue Copy permalink