Merge pull request #917 from lioncash/crash
kernel/thread: Fix potential crashes introduced in 26de4bb5
This commit is contained in:
commit
d43dad001e
3 changed files with 36 additions and 11 deletions
|
@ -28,6 +28,16 @@ SharedPtr<SharedMemory> SharedMemory::Create(SharedPtr<Process> owner_process, u
|
||||||
shared_memory->permissions = permissions;
|
shared_memory->permissions = permissions;
|
||||||
shared_memory->other_permissions = other_permissions;
|
shared_memory->other_permissions = other_permissions;
|
||||||
|
|
||||||
|
if (address == 0) {
|
||||||
|
shared_memory->backing_block = std::make_shared<std::vector<u8>>(size);
|
||||||
|
shared_memory->backing_block_offset = 0;
|
||||||
|
|
||||||
|
// Refresh the address mappings for the current process.
|
||||||
|
if (Core::CurrentProcess() != nullptr) {
|
||||||
|
Core::CurrentProcess()->vm_manager.RefreshMemoryBlockMappings(
|
||||||
|
shared_memory->backing_block.get());
|
||||||
|
}
|
||||||
|
} else {
|
||||||
auto& vm_manager = shared_memory->owner_process->vm_manager;
|
auto& vm_manager = shared_memory->owner_process->vm_manager;
|
||||||
|
|
||||||
// The memory is already available and mapped in the owner process.
|
// The memory is already available and mapped in the owner process.
|
||||||
|
@ -42,6 +52,8 @@ SharedPtr<SharedMemory> SharedMemory::Create(SharedPtr<Process> owner_process, u
|
||||||
|
|
||||||
shared_memory->backing_block = vma->second.backing_block;
|
shared_memory->backing_block = vma->second.backing_block;
|
||||||
shared_memory->backing_block_offset = vma->second.offset + vma_offset;
|
shared_memory->backing_block_offset = vma->second.offset + vma_offset;
|
||||||
|
}
|
||||||
|
|
||||||
shared_memory->base_address = address;
|
shared_memory->base_address = address;
|
||||||
|
|
||||||
return shared_memory;
|
return shared_memory;
|
||||||
|
|
|
@ -339,6 +339,17 @@ ResultVal<SharedPtr<Thread>> Thread::Create(std::string name, VAddr entry_point,
|
||||||
tls_slots.emplace_back(0); // The page is completely available at the start
|
tls_slots.emplace_back(0); // The page is completely available at the start
|
||||||
available_page = tls_slots.size() - 1;
|
available_page = tls_slots.size() - 1;
|
||||||
available_slot = 0; // Use the first slot in the new page
|
available_slot = 0; // Use the first slot in the new page
|
||||||
|
|
||||||
|
// Allocate some memory from the end of the linear heap for this region.
|
||||||
|
const size_t offset = thread->tls_memory->size();
|
||||||
|
thread->tls_memory->insert(thread->tls_memory->end(), Memory::PAGE_SIZE, 0);
|
||||||
|
|
||||||
|
auto& vm_manager = owner_process->vm_manager;
|
||||||
|
vm_manager.RefreshMemoryBlockMappings(thread->tls_memory.get());
|
||||||
|
|
||||||
|
vm_manager.MapMemoryBlock(Memory::TLS_AREA_VADDR + available_page * Memory::PAGE_SIZE,
|
||||||
|
thread->tls_memory, 0, Memory::PAGE_SIZE,
|
||||||
|
MemoryState::ThreadLocal);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Mark the slot as used
|
// Mark the slot as used
|
||||||
|
|
|
@ -265,6 +265,8 @@ public:
|
||||||
private:
|
private:
|
||||||
Thread();
|
Thread();
|
||||||
~Thread() override;
|
~Thread() override;
|
||||||
|
|
||||||
|
std::shared_ptr<std::vector<u8>> tls_memory = std::make_shared<std::vector<u8>>();
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in a new issue