Aphcity/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity Actions

AMD still has broken extendedDynamicState3ColorBlendEquation on RDNA3.

Browse source
This commit is contained in:
Alessio 2024-03-15 13:28:41 +00:00 committed by JuanCStar
parent bc4f5c38fe
commit cc7a70cb6d
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/video_core/vulkan_common/vulkan_device.cpp
View file

@ -595,16 +595,15 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR
dynamic_state3_enables = false;
}
}
// In the past, AMD proprietary drivers had broken extendedDynamicState3ColorBlendEquation
// support. It should work now, even with MSAA surfaces. Uncomment the following code any new
// drivers by AMD bring back the issue as a regression.
// if (extensions.extended_dynamic_state3 && is_amd_driver) {
// LOG_WARNING(Render_Vulkan,
// "AMD drivers have broken extendedDynamicState3ColorBlendEquation");
// features.extended_dynamic_state3.extendedDynamicState3ColorBlendEnable = false;
// features.extended_dynamic_state3.extendedDynamicState3ColorBlendEquation = false;
// dynamic_state3_blending = false;
//}
// AMD still has broken extendedDynamicState3ColorBlendEquation on RDNA3.
// TODO: distinguis RDNA3 from other uArchs.
if (extensions.extended_dynamic_state3 && is_amd_driver) {
LOG_WARNING(Render_Vulkan,
"AMD drivers have broken extendedDynamicState3ColorBlendEquation");
features.extended_dynamic_state3.extendedDynamicState3ColorBlendEnable = false;
features.extended_dynamic_state3.extendedDynamicState3ColorBlendEquation = false;
dynamic_state3_blending = false;
}
if (extensions.vertex_input_dynamic_state && is_radv) {
// TODO(ameerj): Blacklist only offending driver versions
// TODO(ameerj): Confirm if RDNA1 is affected