From c7387e6504db0548fc5dafec5a27ce6923e58db7 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 13 Nov 2018 14:11:34 -0500 Subject: [PATCH] string_util: Remove ArrayToString() An old function from Dolphin. This is also unused, and pretty inflexible when it comes to printing out different data types (for example, one might not want to print out an array of u8s but a different type instead. Given we use fmt, there's no need to keep this implementation of the function around. --- src/common/string_util.cpp | 19 ------------------- src/common/string_util.h | 2 -- 2 files changed, 21 deletions(-) diff --git a/src/common/string_util.cpp b/src/common/string_util.cpp index 5b004ef48b..14f7037d85 100644 --- a/src/common/string_util.cpp +++ b/src/common/string_util.cpp @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include "common/common_paths.h" @@ -33,24 +32,6 @@ std::string ToUpper(std::string str) { return str; } -// For Debugging. Read out an u8 array. -std::string ArrayToString(const u8* data, std::size_t size, int line_len, bool spaces) { - std::ostringstream oss; - oss << std::setfill('0') << std::hex; - - for (int line = 0; size; ++data, --size) { - oss << std::setw(2) << (int)*data; - - if (line_len == ++line) { - oss << '\n'; - line = 0; - } else if (spaces) - oss << ' '; - } - - return oss.str(); -} - std::string StringFromBuffer(const std::vector& data) { return std::string(data.begin(), std::find(data.begin(), data.end(), '\0')); } diff --git a/src/common/string_util.h b/src/common/string_util.h index 7e32d6405b..08f96533b6 100644 --- a/src/common/string_util.h +++ b/src/common/string_util.h @@ -17,8 +17,6 @@ std::string ToLower(std::string str); /// Make a string uppercase std::string ToUpper(std::string str); -std::string ArrayToString(const u8* data, std::size_t size, int line_len = 20, bool spaces = true); - std::string StringFromBuffer(const std::vector& data); std::string StripSpaces(const std::string& s);