Aphcity/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity Actions

common: fs: file: Flush the file to the disk when Flush() is called

Browse source 
std::fflush does not guarantee that file buffers are flushed to the disk.

Use _commit on Windows and fsync on all other OSes to ensure that the file is flushed to the disk.
This commit is contained in:
Morph 2021-06-13 07:47:57 -04:00
parent 56afd4ab4b
commit a98b6c8f07
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/common/fs/file.cpp
View file

@ -309,7 +309,11 @@ bool IOFile::Flush() const {
errno = 0; errno = 0;
const auto flush_result = std::fflush(file) == 0; #ifdef _WIN32
const auto flush_result = std::fflush(file) == 0 && _commit(fileno(file)) == 0;
#else
const auto flush_result = std::fflush(file) == 0 && fsync(fileno(file)) == 0;
#endif
if (!flush_result) { if (!flush_result) {
const auto ec = std::error_code{errno, std::generic_category()}; const auto ec = std::error_code{errno, std::generic_category()};