Aphcity/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity Actions

Vulkan dynamic state 3 blending should work correctly in AMD proprietary drivers now

Browse source
This commit is contained in:
Alessio 2024-03-13 23:46:14 +00:00 committed by Crimson Hawk
parent 9895cc94d0
commit 95bd1120a7
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/video_core/vulkan_common/vulkan_device.cpp
View file

@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project // SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project & 2024 suyu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
#include <algorithm> #include <algorithm>
@ -580,6 +580,7 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR
VK_EXT_EXTENDED_DYNAMIC_STATE_2_EXTENSION_NAME); VK_EXT_EXTENDED_DYNAMIC_STATE_2_EXTENSION_NAME);
} }
} }
// Mesa RadV drivers still have broken extendedDynamicState3ColorBlendEquation support.
if (extensions.extended_dynamic_state3 && is_radv) { if (extensions.extended_dynamic_state3 && is_radv) {
LOG_WARNING(Render_Vulkan, "RADV has broken extendedDynamicState3ColorBlendEquation"); LOG_WARNING(Render_Vulkan, "RADV has broken extendedDynamicState3ColorBlendEquation");
features.extended_dynamic_state3.extendedDynamicState3ColorBlendEnable = false; features.extended_dynamic_state3.extendedDynamicState3ColorBlendEnable = false;
@ -594,13 +595,16 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR
dynamic_state3_enables = false; dynamic_state3_enables = false;
} }
} }
if (extensions.extended_dynamic_state3 && is_amd_driver) { // In the past, AMD proprietary drivers had broken extendedDynamicState3ColorBlendEquation
LOG_WARNING(Render_Vulkan, // support. It should work now, even with MSAA surfaces. Uncomment the following code any new
"AMD drivers have broken extendedDynamicState3ColorBlendEquation"); // drivers by AMD bring back the issue as a regression.
features.extended_dynamic_state3.extendedDynamicState3ColorBlendEnable = false; // if (extensions.extended_dynamic_state3 && is_amd_driver) {
features.extended_dynamic_state3.extendedDynamicState3ColorBlendEquation = false; // LOG_WARNING(Render_Vulkan,
dynamic_state3_blending = false; // "AMD drivers have broken extendedDynamicState3ColorBlendEquation");
} // features.extended_dynamic_state3.extendedDynamicState3ColorBlendEnable = false;
// features.extended_dynamic_state3.extendedDynamicState3ColorBlendEquation = false;
// dynamic_state3_blending = false;
//}
if (extensions.vertex_input_dynamic_state && is_radv) { if (extensions.vertex_input_dynamic_state && is_radv) {
// TODO(ameerj): Blacklist only offending driver versions // TODO(ameerj): Blacklist only offending driver versions
// TODO(ameerj): Confirm if RDNA1 is affected // TODO(ameerj): Confirm if RDNA1 is affected