Aphcity/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity Actions

input_common/helpers: Mark analog property structs members as static constexpr

Browse source 
These are const with no dependency on any other data members, so we can
make these static constexpr to reduce the overall object size.
This commit is contained in:
Lioncash 2022-11-28 10:08:50 -05:00
parent 6291eec700
commit 8265c167d3
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/input_common/helpers/stick_from_buttons.cpp
View file

@ -294,6 +294,15 @@ public:
} }
private: private:
static constexpr Common::Input::AnalogProperties properties{
.deadzone = 0.0f,
.range = 1.0f,
.threshold = 0.5f,
.offset = 0.0f,
.inverted = false,
.toggle = false,
};
Button up; Button up;
Button down; Button down;
Button left; Button left;
@ -311,7 +320,6 @@ private:
float last_x_axis_value{}; float last_x_axis_value{};
float last_y_axis_value{}; float last_y_axis_value{};
Common::Input::ButtonStatus modifier_status{}; Common::Input::ButtonStatus modifier_status{};
const Common::Input::AnalogProperties properties{0.0f, 1.0f, 0.5f, 0.0f, false};
std::chrono::time_point<std::chrono::steady_clock> last_update; std::chrono::time_point<std::chrono::steady_clock> last_update;
}; };

10
src/input_common/helpers/touch_from_buttons.cpp
View file

@ -59,11 +59,19 @@ public:
} }
private: private:
static constexpr Common::Input::AnalogProperties properties{
.deadzone = 0.0f,
.range = 1.0f,
.threshold = 0.5f,
.offset = 0.0f,
.inverted = false,
.toggle = false,
};
Button button; Button button;
bool last_button_value; bool last_button_value;
const float x; const float x;
const float y; const float y;
const Common::Input::AnalogProperties properties{0.0f, 1.0f, 0.5f, 0.0f, false};
}; };
std::unique_ptr<Common::Input::InputDevice> TouchFromButton::Create( std::unique_ptr<Common::Input::InputDevice> TouchFromButton::Create(