From 195cad96355f8d42b84b5c5c58bb4ed34cd77074 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 2 Dec 2018 14:14:32 -0500 Subject: [PATCH] yuzu/configuration: Make slots private where applicable These slots are only ever attached to event handling mechanisms within the class itself, they're never used externally. Because of this, we can make the functions private. This also removes redundant usages of the private access specifier. --- src/yuzu/configuration/configure_audio.h | 3 +-- src/yuzu/configuration/configure_debug.h | 1 - src/yuzu/configuration/configure_dialog.h | 1 - src/yuzu/configuration/configure_graphics.h | 1 - src/yuzu/configuration/configure_web.h | 3 +-- 5 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/yuzu/configuration/configure_audio.h b/src/yuzu/configuration/configure_audio.h index b55b53974f..8771421c0d 100644 --- a/src/yuzu/configuration/configure_audio.h +++ b/src/yuzu/configuration/configure_audio.h @@ -21,10 +21,9 @@ public: void applyConfiguration(); void retranslateUi(); -public slots: +private: void updateAudioDevices(int sink_index); -private: void setConfiguration(); void setOutputSinkFromSinkID(); void setAudioDeviceFromDeviceID(); diff --git a/src/yuzu/configuration/configure_debug.h b/src/yuzu/configuration/configure_debug.h index ac0d04acba..c6420b18c1 100644 --- a/src/yuzu/configuration/configure_debug.h +++ b/src/yuzu/configuration/configure_debug.h @@ -23,6 +23,5 @@ public: private: void setConfiguration(); -private: std::unique_ptr ui; }; diff --git a/src/yuzu/configuration/configure_dialog.h b/src/yuzu/configuration/configure_dialog.h index df23a0801d..f6df7b8276 100644 --- a/src/yuzu/configuration/configure_dialog.h +++ b/src/yuzu/configuration/configure_dialog.h @@ -25,6 +25,5 @@ public: private: void setConfiguration(); -private: std::unique_ptr ui; }; diff --git a/src/yuzu/configuration/configure_graphics.h b/src/yuzu/configuration/configure_graphics.h index 8688003e41..d6ffc6fded 100644 --- a/src/yuzu/configuration/configure_graphics.h +++ b/src/yuzu/configuration/configure_graphics.h @@ -23,7 +23,6 @@ public: private: void setConfiguration(); -private: std::unique_ptr ui; QColor bg_color; }; diff --git a/src/yuzu/configuration/configure_web.h b/src/yuzu/configuration/configure_web.h index 61d8149f67..7752ae4a13 100644 --- a/src/yuzu/configuration/configure_web.h +++ b/src/yuzu/configuration/configure_web.h @@ -22,13 +22,12 @@ public: void applyConfiguration(); void retranslateUi(); -public slots: +private: void RefreshTelemetryID(); void OnLoginChanged(); void VerifyLogin(); void OnLoginVerified(); -private: void setConfiguration(); bool user_verified = true;